[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] public/trace: Add U suffix to TRC_PV_HYPERCALL_V2_ARG_MASK
- To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 Dec 2025 12:06:28 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CVBI/kQmLsGOHt+//8JzIikHLFqytSb6UmPY9cwUaes=; b=mR94UfwG2udsQRoAvpwjFpdGQNt8SYpivr7/L5lbA1LMj5qnynVQltCLLcHMYL8wgm5h/r027ZXl960xjn44vcGMM04fMP+TyjH9e2387TFd0TYbOvNDyP+ZSK2ghzyTQD+DMZzxJGSoIRHZ7G2eubfVzuI/95hrirO7mnOP/4zgcRdQ55Sg00w/8r7md2SJlwzL4pf9rODxv1ZERinN6T5EKpLSrRjooHBTcEq6Z1Pd41IeIi9NHJJW/8xN/dw1WGMC0Zd9slbG63Fp/i1gxuI2wCAw3Dkc1/dp149HnCV3EtinQ83OxcLI6CfOiARGDbUQOJiDP28Qj/ffpCkKiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CuO1VEC+w/zwlukU76wICEkkvEjZZ0oC36hDrAA9vJ8t5uXIh79H/8QmLT3LRToqrv3637F7LtHfx2Ljc80HtYIvoUTVVk8QGyORb67bmYQGME9Q79uPCooMEPRBaDRxPtjLMle1Zak3wBuDyIQys7GbcHmm8cgTQiohZLfN0h0x6uw6Mmec9A3jg4/E9H/wYeMcTInW+IDkn1Casue33kV6QZgOPfNxSdt8yYrx08Wbri+K/HSpt04N+jBBb/Lji6jm/cquvYBqLl5ek7de+9y3STBnLLBss6YmK1gWFMRZS+NEoUNdXEKI+DttRuAD8m7G7tOZXsPgyEkPZGrLlg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 05 Dec 2025 12:07:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/12/2025 11:49 am, Michal Orzel wrote:
> TRC_PV_HYPERCALL_V2_ARG_MASK represents unsigned type, so according to
> MISRA C R7.2. U suffix should be applied. Fix the violation.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> xen/include/public/trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/public/trace.h b/xen/include/public/trace.h
> index 141efa0ea7b9..a7d7fb8c507f 100644
> --- a/xen/include/public/trace.h
> +++ b/xen/include/public/trace.h
> @@ -157,7 +157,7 @@
> */
> #define TRC_PV_HYPERCALL_V2_ARG_32(i) (0x1 << (20 + 2*(i)))
> #define TRC_PV_HYPERCALL_V2_ARG_64(i) (0x2 << (20 + 2*(i)))
> -#define TRC_PV_HYPERCALL_V2_ARG_MASK (0xfff00000)
> +#define TRC_PV_HYPERCALL_V2_ARG_MASK (0xfff00000U)
>
> #define TRC_SHADOW_NOT_SHADOW (TRC_SHADOW + 1)
> #define TRC_SHADOW_FAST_PROPAGATE (TRC_SHADOW + 2)
Hmm. Ideally we should use _AC() (or whatever monstrosity we call it in
the public headers), but this header contains C structs unguarded by
__ASSEMBL{ER,Y}__ so we don't need to be so careful.
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> but if you're
changing it, you can drop the brackets too.
|
