[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/4] CI: Add configure --enable-systemd for full build


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 4 Dec 2025 21:54:41 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ph8kVgQlggGqAwLK034umbgOLoBGvg/LjuMxWOhhe3c=; b=WU4ZDbM5ql/yrXEJLbRnVj6QzyvCGy2DLrMyp6/8iv1thN9Tkd2GCKQigxYVoL/dHp+8/HSFJYSFQn1LCY+gAh2T2PCnOyI579OjQKjZqi/T6YN0t86+5/p6cKa6YOz5C5cISZNt6w1AA6B79fsomjDBheBPH8kzM3brlL58auvD0vENU/58ViiweinRUtG6MA2HKdzAaiJc0EaVba9zjTBHXpdFmRgiANo4hL0rvLAZPkdEjnVuHrnrVT4+ds9gYN1OrWyQdxMx9Wz62jngpo+/I3i1GSXWMa66ZgXQsD403oPDROEzjysuT6JYG6twAX9uCGdhCjUgiqHxevtcyw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wmqRzuViz6cqlMsQOfYpkthaNtPoEZ+kJ4jriXCxEQhsLmHrvEQHJ1c+34gDJshCoHmgn7nbBOAky9smPcOVrDaPiDNGYgOmIzdcCOPDCSgyhMF4iRr1yRhSYt5UIkqpmxCt2fX7wMgbGTzwG5DY0OUs9DjkhfhaSlCiDy+Ppf7nsCzlBwT03cMwbBV1PLh6+uSczxfgztZF/JswioZi5Bt/k7fzmkWOGHGcdop5LxTMtEeK9Yl1UXZbYqpFKRibG9rts0rTlXf/uYlcTmNbIYa9bv1WgIwmoB1/r1DiszOSUsT0cSAxHIWtpPEYkEVMEVzNkiBc6BeIDdYCQO/n3g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: andrew.cooper3@xxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Thu, 04 Dec 2025 21:54:50 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04/12/2025 4:53 pm, Marek Marczykowski-Górecki wrote:
> This doesn't exclude sysvinit scripts, but allows testing systemd too.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Oh - I had a task to make this happen by default, which also missed
4.21.  It's bad that configure does the wrong thing by default for systemd.

> --
> Changes in v3:
> - switch to trixie
>
> New in v2.
>
> Requires containers rebuild
> ---
>  automation/build/debian/13-x86_64.dockerfile | 1 +
>  automation/scripts/build                     | 3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/automation/build/debian/13-x86_64.dockerfile 
> b/automation/build/debian/13-x86_64.dockerfile
> index 6382bafbd5bd..9387da453fea 100644
> --- a/automation/build/debian/13-x86_64.dockerfile
> +++ b/automation/build/debian/13-x86_64.dockerfile
> @@ -26,6 +26,7 @@ RUN <<EOF
>          cpio
>          git-core
>          pkg-config
> +        systemd-dev

Why is this needed?  Or rather, does this patch predate my breaking of
the dependency on system-dev?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.