[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 20/24] xen/x86: wrap x86-specific domctl-op with CONFIG_MGMT_HYPERCALLS
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Thu, 4 Dec 2025 04:23:22 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t6lENOaPQIzFqzDTuMRuVnqLQvMfY2zoaYbAAVvrO0M=; b=CqH9ES+I8BGvSN2fDE1OU18syVOLw2Lyr31jC/H6IvLIwbShoCSlCxzdrzZdjrjS0ckgIo3GXbBtE+4lrZYNhxNcJBZ4qqtH4u+QHS1fLWvzUU/aV99XR4Sxf5jNnEXy6sOe9z1LqnhtKVEUU83h4SLR6F5lDMYZ5vTJcGS7xk7a0C9r6HfaB14Vr/NVm8Joj+Dc7Q/jARtbPpuJJjlJnczGyVCrYOr+98x0YyVGvev8hkBFgZCseFVKeqvWhW1exK1WEdHdhzDnqW/V58KzVdM7Jx4q3pX4txygRlLFYbJPUEsmzHHkd79w5PGgeB+8fzoMKE7H/8Kl66bRYEmDjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CYQXWhCvl+PVnX8ZrsBsbwbZq75awJuiAZztayIjvq1CHmaKkGrCescybdsMM8q2FGEHVn+5fESeacamb9n2o66SRnNjrDbeCHH//HA4ey6iy4NICYX9H7bP7RK9BD0jCoKh9NTzGg6mc/xjDAudRYQOvPqdoivoyiBK9B4KPIIqsdj08KI/nT/9iJxNhilvPOquxaino0ITSgIwPVIO1lpNnkqXXNChwycBGLbSueXF25MFdk23b/EieHQeEZg2vJBGFsnSl9jDGHM55g3+mZQIq2R59t7W9Il4O6C+xDqdygBoiT/LuRXSUGm5Hi75d2EuAK3yWo7tudBRj1uZxQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "grygorii_strashko@xxxxxxxx" <grygorii_strashko@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 04 Dec 2025 04:23:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-12-04T04:23:15.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcWtXmS51F6WJwgE2h9vzl8XgXOrUDpDaAgA1N7rA=
- Thread-topic: [PATCH v4 20/24] xen/x86: wrap x86-specific domctl-op with CONFIG_MGMT_HYPERCALLS
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, November 26, 2025 1:00 AM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; grygorii_strashko@xxxxxxxx; Andrew
> Cooper <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD
> <anthony.perard@xxxxxxxxxx>; Orzel, Michal <Michal.Orzel@xxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; Daniel P. Smith
> <dpsmith@xxxxxxxxxxxxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 20/24] xen/x86: wrap x86-specific domctl-op with
> CONFIG_MGMT_HYPERCALLS
>
> On 21.11.2025 11:57, Penny Zheng wrote:
> > --- a/xen/arch/x86/Kconfig
> > +++ b/xen/arch/x86/Kconfig
> > @@ -29,7 +29,7 @@ config X86
> > select HAS_PCI_MSI
> > select HAS_PIRQ
> > select HAS_SCHED_GRANULARITY
> > - imply HAS_SOFT_RESET
> > + select HAS_SOFT_RESET if MGMT_HYPERCALLS
>
> Why would you undo an "imply", when really we should use it more? One of its
> purposes is so that you can add "depends on MGMT_HYPERCALLS" there, and it
> then won't be auto-enabled if that dependency isn't fulfilled.
>
> > --- a/xen/arch/x86/include/asm/paging.h
> > +++ b/xen/arch/x86/include/asm/paging.h
> > @@ -55,7 +55,7 @@
> > #define PG_translate 0
> > #define PG_external 0
> > #endif
> > -#if defined(CONFIG_PAGING) && !defined(CONFIG_PV_SHIM_EXCLUSIVE)
> > +#if defined(CONFIG_PAGING) && !defined(CONFIG_PV_SHIM_EXCLUSIVE)
> &&
> > +defined(CONFIG_MGMT_HYPERCALLS)
>
> This line is too long now.
Hmm, how about I introduce a new Kconfig, something like:
```
diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index c808c989fc..ec8f51b0b1 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -166,6 +166,9 @@ config SHADOW_PAGING
config PAGING
def_bool HVM || SHADOW_PAGING
+config PAGING_LOG_DIRTY
+ def_bool PAGING
+
config BIGMEM
bool "big memory support"
default n
```
Then, later future dependency could be added to PAGING_LOG_DIRTY
> Jan
|
