[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/10] xen/arm: ffa: refactor direct requests via RUN helper
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 3 Dec 2025 14:22:31 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linaro.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qAY2NJoKF6dhvdCIt7QIOTlfzvtsswO8KDntMLjoqbk=; b=HdfM9a+bx6FkdwYlElDaPcFdMEaXe4ClGbKF2s0slavKS23PqhFif0Bz7blQMdMgEEcIGr0kWZTSRt4qb/DL7dvxiRujxaa62F3vTlmM+e8oQRDdMvN69a5TzR7P17CmrGvFHkLjkym5euNIptpl4eRUo8fWyctZPvDqfjJDz53cXy0lPfKnFJTxmH+89I0XUTmdqOgZyQZtCy5F4/f+xJh1mJKP0dAilICMPWX759QEnB8HjvzbqPXGM1y7Ofc3BjEV78o5SoAupMTtIgh582tiC3zYvsJ9uPSrlTNavIKOQiSOPbtZql2a8zQ2twJyeNjNFqHEKnZfvFIj3vOEZw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qAY2NJoKF6dhvdCIt7QIOTlfzvtsswO8KDntMLjoqbk=; b=y6iZbLEJVNIx3ppYKSo/gAymtI0n5D0cRjTcuEZVzlIR6CHgnfkyCj+lfzK0ru1SOGDyCxrAfb+snE/jr8m2s/3OVlSdw3Vi/NH3hSpEeS5QoqfkVZEikkx4jFdJ6O/0Y0p0V3KlKBrhkZyp2oIXXUYG439B2gaO07UF1IMtDMysjzBOMadywPCtatHG9TBf/KgrsAYXa767nIFAOcFCceOaYGSM0/Jj9jLCDurcnr28tLu8ZbeomRBCOBkLaWd9z+XrWGolLom75ifTsdHFP22IkflmXSlC6szsNDtzpzHWFrI/dSyi8t+QKKeSXDbbLpxxNp3Gk/fDs+4bsQPdlw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ppwpAlkaf7geG4ca2ay2yIk/J7CDMrNJrX/z1cXKdODckP7WTd4FZ5E6txEX1v9B7EvaDa6DwTLfMz7h+ity9ny2JDqzTZzx+TDMLtzv5QN0EJD4yeWLh+n7J92u1LXDTyohXAtXu81frvQRldD25j8JIEb/PTksWo4KaAmiKHgSV3VurmrMUmMW616zA4473vUjN7Fa1Xv8KDj7B1WqF5q61iaPqAnxHR6EhnLm5zveE5cJHy8MkBHrgWaRARaeUM/i6EZvIVAZODl/XL1+nVB4Ee1znscIWMb/NNl9dxx+Ae7R6G6BPsX+gk9RJ48kbtVnw311CeiNfcUiEkeTeQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MyUDAhHKhvYnABkmFt1v4TMrt030E/JppYflnZSbB7VKE+pFggCnGTTuJUJyvXO6z5I04xAbwULMH62uEOn/inmR5mu+erPGVOX+1Q3jxr0B4r3ci80jVX0k9jLQ3WPDIjkNripUKhPPWWA97t2yZSCbH3Rzcze8YoaWE4LoMompAC2vliP2hAhToEn41+0fdtLlKkk6ILaPyu9r5Uvk5+Oi8Zvx/NabpZrXgGY52gC8IJCk4pSkpVHxSuErE8KQp4sB2BNC/T/aq7Ds0VS8JvUAiMV8q7uResebUjpyZcbiwnvjKGzKNlOVOCntWOCQNvh6dpphfQD9p2V4RWCdYQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 03 Dec 2025 14:23:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcX7X0sGAu99JlG0eRwdEB2YckarUP+a4AgAAHX4A=
- Thread-topic: [PATCH 07/10] xen/arm: ffa: refactor direct requests via RUN helper
Hi Jens,
> On 3 Dec 2025, at 14:55, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>
> Hi Bertrand,
>
> On Thu, Nov 27, 2025 at 4:53 PM Bertrand Marquis
> <bertrand.marquis@xxxxxxx> wrote:
>>
>> Share the SMCCC plumbing used by SEND_DIRECT and RUN via a common
>> ffa_finish_direct_req_run() helper so canonical success and error cases
>> are handled in one place.
>>
>> The dispatcher now routes FFA_RUN through ffa_handle_run(), and direct
>> requests bail out early if a guest targets itself or a non-secure
>> endpoint. This simplifies the direct path and prepares the mediator for
>> the wider v1.2 register ABI.
>
> From the above, it sounds like FFA_RUN was already supported, but I
> don't see how.
Yes It seems i forgot to rework the commit message when i rework
the split in my serie.
I will update the commit message in next version.
>
>>
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> ---
>> xen/arch/arm/tee/ffa.c | 3 +
>> xen/arch/arm/tee/ffa_msg.c | 111 ++++++++++++++++++++++++---------
>> xen/arch/arm/tee/ffa_private.h | 1 +
>> 3 files changed, 84 insertions(+), 31 deletions(-)
>>
>> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
>> index 7392bb6c3db9..92cb6ad7ec97 100644
>> --- a/xen/arch/arm/tee/ffa.c
>> +++ b/xen/arch/arm/tee/ffa.c
>
> FFA_RUN should be removed from the list of unsupported FF-A interfaces
> close to the top of this file.
In fact i do that in the last patch of the serie with adding support for FFA_RUN
in ffa_features but this does not really make sense as this is not bounded to
1.2.
I will move those from patch 10 into this one instead in next version.
>
> The rest looks good.
>
Thanks
Cheers
Bertrand
|
