[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/lib: Introduce SHA-1
- To: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 2 Dec 2025 16:39:27 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XNiCogE6Pi2TTTBLzbjTvI7Jluz7Q9CDEMTi2mlQm50=; b=hOs+PhgrmV1Mn5XNRRjjLxL3bfylARgQ7m4AK97wDNRzip/T/88cm20qldHGqG/w+6UUppeYn1mMtUfFqbZ2a2gq7CTwZEiReEVtHBob9S4HwElWOooqZN1NM0LFKe9dewOXbDU5+3eGfJ4M5WH6Ekr0euyuolTjzb5xNjcHlr1PSeDRPRfoC1qvXyXkaDpg+AuVDNVmv5oSTTrILp61ospOJizDSdwYHJ7BglQFA7YcZO0YwN4NgCO0RamVQAAEy7djY3/AC4MAZUubw4uDXBdrXZUO7Drf7bFELdJhU+/spQlIui3M2CFc1Fr3dQIxk1k+/Z9q0yY6em+O/JHfhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LbIf4JMge8OS+UCiFJto5uyD/KkdnJ4VIpxANRdVWk44xFl8NYYvrzJxL44wlpn1+eVsYN9pSfhTXVYyZxXkfZzMGPYaKklNkJWN7RTe7D0SxtZQwVbLelaYKNkoix0Ln+9xbevzia5u9tKHF+mMDP86Na/99doPXSU2YTBXy6t10AAeJB2xDg7YgedLfsbhlakeVQOYy/6X/u4HZdQVmt+yxrSe3BUdXA4QkkA+2fJalrDcxfzu+m9ySoazcjV7e0hqmXOLvi1fOV5ZzzGlgcxuWK0V3Y304zoZ3KoC+hKWF/Dw/1atfLJc1p8jgsL/FBKG1Qn+silrvDAgkMEX0Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Krystian Hebel <krystian.hebel@xxxxxxxxx>, Sergii Dmytruk <sergii.dmytruk@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 02 Dec 2025 16:39:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/12/2025 2:24 pm, Jan Beulich wrote:
> On 01.12.2025 15:19, Andrew Cooper wrote:
>> On 01/12/2025 8:46 am, Jan Beulich wrote:
>>> On 28.11.2025 19:47, Andrew Cooper wrote:
>>>> --- a/xen/lib/Makefile
>>>> +++ b/xen/lib/Makefile
>>>> @@ -17,6 +17,7 @@ lib-y += memset.o
>>>> lib-y += muldiv64.o
>>>> lib-y += parse-size.o
>>>> lib-y += rbtree.o
>>>> +lib-$(CONFIG_X86) += sha1.o
>>>> lib-$(CONFIG_X86) += sha2-256.o
>>>> lib-y += sort.o
>>>> lib-y += strcasecmp.o
>>> Why exactly are we confining the two SHA<n> to x86? They're both plain C
>>> implementations, so ought to be fine to build everywhere. Being in $(lib-y)
>>> they also wouldn't make it into the final binary until a reference would
>>> appear.
>> For the SHA2 patch, an objection was made to compiling it on the other
>> architectures. Personally I think they ought to be plain lib-y.
> Everyone (not knowing where the objection came from) - can we please re-
> consider this, ideally ...
>
>> I could always have patch 1 fix up to lib-y and have patch 2 match...
> ... allowing this to be done?
FYI, we discussed this on the committers/maintainers call, and decided
that lib/ does want to be generally enabled.
As such, I'll do as suggested. Have patch 1 make sha2 non-x86-specific,
and have patch 2 be general from its introduction.
~Andrew
|
