Re: Ping: [XEN][PATCH v4] xen: make VMTRACE support optional

[Grygorii Strashko <grygorii_strashko@xxxxxxxx>]

On 02.12.25 12:57, Jan Beulich wrote:
> On 19.11.2025 20:31, Grygorii Strashko wrote:
> > From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
> >
> > The VMTRACE feature is depends on Platform/Arch HW and code support and now
> > can be used only on x86 HVM with Intel VT-x (INTEL_VMX) enabled.
> > This makes VMTRACE support optional by introducing HVM Kconfig option:
> > - CONFIG_VMTRACE to enable/disable the feature.
> >
> > Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
> > ---
> > changes in v4:
> > - format changes
> >
> > changes in v3:
> > - drop vmtrace stubs for HVM=n case from hvm.h (VMTRACE depnds on HVM)
> > - hvm_vmtrace_reset() fix return err code
> > - add comment about using func declaration without definition
> >
> > changes in v2:
> >   - fix comments from Jan Beulich
> >   - move CONFIG_VMTRACE in HVM
> >   - drop HAS_VMTRACE
> >
> > v3:
> >   
> > https://patchwork.kernel.org/project/xen-devel/patch/20251114142207.279834-1-grygorii_strashko@xxxxxxxx/
> > v2:
> >   
> > https://patchwork.kernel.org/project/xen-devel/patch/20251112202442.3879997-1-grygorii_strashko@xxxxxxxx/
> > v1:
> >   
> > https://patchwork.kernel.org/project/xen-devel/patch/20251031212005.1338212-1-grygorii_strashko@xxxxxxxx/
> >
> >   xen/arch/x86/domctl.c                   |  4 +++
> >   xen/arch/x86/hvm/Kconfig                | 12 +++++++++
> >   xen/arch/x86/hvm/vmx/vmcs.c             |  2 ++
> >   xen/arch/x86/hvm/vmx/vmx.c              | 11 ++++++++
> >   xen/arch/x86/include/asm/guest-msr.h    |  2 ++
> >   xen/arch/x86/include/asm/hvm/hvm.h      | 36 ++++++++++---------------
> >   xen/arch/x86/include/asm/hvm/vmx/vmcs.h |  2 ++
> >   xen/arch/x86/mm/mem_sharing.c           |  2 ++
> >   xen/arch/x86/vm_event.c                 |  8 +++---
> >   xen/common/domain.c                     | 10 +++++++
> >   xen/common/memory.c                     |  6 +++++
> >   xen/common/vm_event.c                   |  3 ++-
> >   xen/include/xen/domain.h                |  4 +++
> >   xen/include/xen/sched.h                 |  4 +++
> >   14 files changed, 80 insertions(+), 26 deletions(-)
> Tamas - any chance of an ack here?
>
> Grygorii - chasing missing acks is generally the submitter's responsibility.
Sorry, I switched to different task and forgot to ask :(
 
> Jan
--
Best regards,
-grygorii