[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] x86/amd: Use setup_force_cpu_cap() for BTC_NO


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 26 Nov 2025 15:12:36 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6X+zrkOru28E9z6Djnzq4bZXKaUj/XCtqM/4pCzRJEI=; b=XLn0KdIEHj7XpqSo6sfOyGJe7cOXp8zUJE6TibpcfrQOMBoCWzJuVH9BuMMo2k3vcWEmmx9Tm+Z3QVSSOJhd2KDCZVYTbEbbcQUlJDdnyfKtx8VCn5+Psd3Y3FwZ3zjPix+4DQzo6TbygMaZzu5Mks0Xg1sbDvpUxHLmqHf7kkF4VzK5bzv4bZc4DcUy+xxyBM2ZleMT0LbzfPY3LrbL+t8b3EclHBL5EHm0ZwAg+1zsm0WWqMyelSHIIot8u1rDW/s4JDMk14Wti7u06lMrVmC5yzts+eaH1ioeZdb92phZH5+wI8xmMdeaJXwtQwbca+b2kY3S0tsAx6A/tEiJ2w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zGa1+ZEoXF+Mg7OpswRbrLHdwAYK0p/vwx3DbsPxYDWevi96oif/KTkdwLaslb1NAEpWbXxWxtjb5MxBbNtD8kW0drrDUWOtxCbJHCr1xNx3Nmqnhd9k1ZOcXTwuDB7Q/wNzTP9saLhFamXGlDgsvXG21b0N+1XWqDA+rRoSa8djLjPDHWBJoQvtb/G43+ts1LN4LDAOk+WPqKBkA2ZmNp8lmfa10f2aDNIFcCltqlvU75ZxnmTEwJRw9BsbzGSvd7HUNx9wmqIQLJ/2/aTU+CQxhmHj4V1M0KMYS/QXjO++3oOQFcZqbZAGAOcybWteF0npKc9OJOQgwwLjPRZp4w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: andrew.cooper3@xxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 26 Nov 2025 15:12:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26/11/2025 2:19 pm, Jan Beulich wrote:
> On 26.11.2025 14:22, Andrew Cooper wrote:
>> When re-scanning features,
> What exactly do you mean with this, outside of XenServer (i.e. upstream)? The
> only thing I can think of is recheck_cpu_features(), which calls 
> identify_cpu()
> and hence init_amd(). Thus ...
>
>> forced caps are taken into account but unforced
>> such as this are not.  This causes BTC_NO to go missing, and for the system 
>> to
>> appear to have lost features.
> ... I don't really follow where features might be lost.

Well - it's a feature that we started upstreaming and I still hope to
finish in some copious free time.

Already upstream, we rescan the Raw CPU policy after microcode load. 
That has had fixes such as dis-engaging CPUID Masking/Overriding so the
Raw policy comes out accurate.

The next step (not upstream yet) is to regenerate the Host and Guest
policies.  I recently fixed a bug in XenServer's testing and noticed
that the underlying logic had bit-rotted quite a bit, hence this series.

The purpose is to be able to activate new features added by a late
microcode load, such as new speculative defences, or simply provide new
FOO_NO bits.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.