[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] x86: move / split usercopy.c to / into arch-specific library


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 26 Nov 2025 13:56:27 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93VQO2cOhgeG8fPNlomfUuzlTmlapsYgyTp7wVTLIj0=; b=wwYwGP51vPmT4Ch4ybquSvYRtcmTaimqmccHzfDreEM3TjlLdZzbwTCYAih4yiTQpg41o0W/PP+x4vQRlaSQTf9IZKxgTDRTbAdWGlZwpPSp9xcjowm7VVzDQ2LV32Mg8dUBzKhOITi8lRNrv84S6NH0mUrwgxl1THdC7awUtn2gHY7r6+d93k2lVBh7bqIdZWdbYYDfuonwLGa9lL5jCoVZRB70630zEOFDSi/hcBtjDYLiGl8JVmBhpbhQH1dVVoIyUUH36WSuRJ61wx4JDbJJczZART/cupzXHSTCziEHkilFv4ez/bJ70eGxhL+1wD03P33zpgd84laCDcWgvA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QhA8xLgzgHi/UBR8u4/uZgjzw7IjhKLI5rLuWzuil5rYs1xO+OdZQ5oOwaExYpRceQaowKTKPPp5yGAcSrgYilnyfTKy7sYEmlfhZS47nlZF77d7d8xSobXBuc7bpZk39JAoI75/P1oUJLpxyHjYZ0YTiQLqf0HqnSXA4Rxax9Y7wjVTqSuaqQ0EtzCXk33b5Hwi7PIOdzagi/9FxZs8Ir1aHMqkbF9/JNoLha7ZXexUlSVUDQejFJlXwfPeD0bMl0UzslEawzySkWY6ZEBPw/mSFZIqmMJPw24tD/07Mesq4J9IiEytMrQA8+HQC/aHh4JS9mwS4RdzKdl1BaHPjw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: andrew.cooper3@xxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Grygorii Strashko <grygorii_strashko@xxxxxxxx>
  • Delivery-date: Wed, 26 Nov 2025 13:56:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26/11/2025 1:24 pm, Jan Beulich wrote:
> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> index 61e2293a467e..76540d77e55f 100644
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -72,7 +72,6 @@ obj-y += time.o
>  obj-y += traps-setup.o
>  obj-y += traps.o
>  obj-$(CONFIG_INTEL) += tsx.o
> -obj-y += usercopy.o
>  obj-y += x86_emulate.o
>  obj-$(CONFIG_TBOOT) += tboot.o
>  obj-y += hpet.o

There's

# Allows usercopy.c to include itself
$(obj)/usercopy.o: CFLAGS-y += -iquote .

which looks like it wants moving too.

But, given that this presumably compiles, doesn't it mean we've got a
search path problem anyway?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.