[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: Remove x86 prefixed names from cpuinfo for intel.c
- To: Andrew Cooper <andrew.cooper@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
- Date: Tue, 25 Nov 2025 20:05:01 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ceOcAwmy4+3wlEaLWq+sxz5OCpsNV7rRkkM2/YOiHbo=; b=w9NcEItirWe8tqLBSIms38ee6k0HUP4+/fMX0epYscBZgAowwgSD+61bxTWzMYzkOzWFdCv61V1nye9Er0oSHyethG57Td1GHBEEe2oo+57dhOUOfJOp3bf27CvMuoRfuXEXcb9isMbpDVpLv17G91JBqbiiyGFyUebVMcQ60OefR80K8yEFiVFhhzNEGlE4ARRNLSqbHRWzCcb7rs4xDTeGLzaewp+uJ6JUGQtnRcj/RmxXD2Jc8/DViSJ6Oa9Odn7GI+o5K8F49drrh13UkbBXJYPXBC8/oIow8zMWnwfe+rzkaz77XiqolGTIWO8NoSG9BV4iW3W+cO3DfUv5tQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M+2XoFkvwlcFJKO8WSNGM9e4l9oMwsszIjcjKFy2Ql0KtcuPb772dtS/eLuybBHXIbFj0rivdriXWNt0ykkuJdwQaGPyUCG1LImwvoyzbq5anQ9wJ5FcgZi8VxNpotxfb+RToK7EyOMY+Jd86NdhuLi/thXPqDxA6riyJ5VDn6Yf2aiR3gLRuzKl6hLDc2WUOd/czx2tmwZm7Ku6P40nTcTVFH57SVSu79i7Lm2gYRwxX92D7SfS+KH/KDe1WrvpIJR3TRiDHZvf/QFMU1ezKZYCRZ8j4EQcNg4TPAw/cwSuiwZcslY/hym1Cny1LSafaC3MRhURACONUc3oYu/Y1Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 25 Nov 2025 20:05:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHcXTQ73Jy0r9eIAkCAIFbbEnPqPbUCS7kAgAGHQ78=
- Thread-topic: [PATCH] x86: Remove x86 prefixed names from cpuinfo for intel.c
|
Sorry I will pay more attention to the surrounding code in future.
From: Andrew Cooper <andrew.cooper@xxxxxxxxxx>
Sent: 24 November 2025 8:44 PM
To: Kevin Lampis <kevin.lampis@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Cc: jbeulich@xxxxxxxx <jbeulich@xxxxxxxx>; Roger Pau Monne <roger.pau@xxxxxxxxxx>
Subject: Re: [PATCH] x86: Remove x86 prefixed names from cpuinfo for intel.c
On 24/11/2025 11:19 am, Kevin Lampis wrote:
> diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c
> index 6f71365b7e..5f780fe1aa 100644
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -86,7 +86,7 @@ static void __init check_memory_type_self_snoop_errata(void)
> if (!boot_cpu_has(X86_FEATURE_SS))
> return;
>
> - switch (boot_cpu_data.x86_model) {
> + switch (boot_cpu_data.model) {
> case 0x0f: /* Merom */
> case 0x16: /* Merom L */
> case 0x17: /* Penryn */
One of the reasons of making these changes is identify the places
needing converting to VFM. This is one, and...
> @@ -137,10 +137,10 @@ static void __init probe_masking_msrs(void)
> unsigned int exp_msr_basic, exp_msr_ext, exp_msr_xsave;
>
> /* Only family 6 supports this feature. */
> - if (c->x86 != 6)
> + if (c->family != 6)
> return;
>
> - switch (c->x86_model) {
> + switch (c->model) {
... so is this.
~Andrew
|
|
