[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XEN PATCH] libxl_nocpuid.c: fix build with json-c


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Michael Young <m.a.young@xxxxxxxxxxxx>
  • Date: Fri, 21 Nov 2025 21:09:04 +0000 (GMT)
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=durham.ac.uk; dmarc=pass action=none header.from=durham.ac.uk; dkim=pass header.d=durham.ac.uk; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kv42ZEkgyrPpVrzR/AloL9B9AKQMGqD2iqG3U1yBZO0=; b=ZprgkuGgKE/sP4YDJeahPFdDDkatn3kVQAY0OCorZJT4DtTHj9UXXUhSCbcN1vblYtdG28aQTngY3W+U5E+69cSqgPLi8l3t+0Sfl9yZKAmE3K3pJUiu2eXuW2YJZfCiuCE5GLze06wpjH3pjWYuaRaCWBqa4tPikMuga01SARCbtF1//CtIkSoVIgItO4sWZWs8ZOaROlwF6Ma958NJYTM9dGEHrl/gosQ8aE7bbOOMBfojHG8ZzhWzLFRxtdazIcaDHnXtGrghsK7qpcfnb+z2ERt+QJF+u47Ndlr1hcAe1vVXIbPckepxiE3keC2M5crcftP4+OSPH8K371bJYg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PpRDrdRGoCR4Sq/qFqMh6WdteAke6ohsNmS6t7NaPBPbHKTeifyoXt1TtR8wK4Ug/4g7gCV6tAOY4fO9eUoiwDL11v0fdMg8nbZpto7l7ebHLJnpFX7/8Gk7denhDH+8ss7+g+bRE849jb1pbDWoCvjwWHuPcokuWa874U9TNWU/gG1iSWejvi9MAkzATBPC2BCoGFhfbaIqhUUnxyND3ABOCe6IosMH/vJPklotMtxArr/1/ku0w63KEiH4Musq2CtXeVkCgCyo3Rbix+hpKr7J8iPOI2u822yKjI5Nq8XQS50xaWVcQLtQTTlwG/ZWVHoIJ/Aq2mMTMnQwipk3iA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=durham.ac.uk;
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Fri, 21 Nov 2025 21:09:25 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The build of xen-4.21.0 with json-c present and yajl not present
is failing with the error

libxl_nocpuid.c:43:1: error: unknown type name ʽyajl_gen_statusʼ
   43 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
      | ^~~~~~~~~~~~~~~
libxl_nocpuid.c:43:50: error: unknown type name ʽyajl_genʼ
   43 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
      |                                                  ^~~~~~~~
make[6]: *** [/builddir/build/BUILD/xen-4.21.0-build/xen-4.21.0/tools/libs/light/../../../tools/Rules.mk:178: libxl_nocpuid.o] Error 1

I tested it with the patch below based on libxl_nocpuid.c which did build.

Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>
---
 tools/libs/light/libxl_nocpuid.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tools/libs/light/libxl_nocpuid.c b/tools/libs/light/libxl_nocpuid.c
index 0630959e76..71ab49ed61 100644
--- a/tools/libs/light/libxl_nocpuid.c
+++ b/tools/libs/light/libxl_nocpuid.c
@@ -40,11 +40,24 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore,
     return 0;
 }

+#ifdef HAVE_LIBJSONC
+#ifndef _hidden
+#define _hidden
+#endif
+_hidden int libxl_cpuid_policy_list_gen_jso(json_object **jso_r,
+                                libxl_cpuid_policy_list *pcpuid)
+{
+    return 0;
+}
+#endif
+
+#if defined(HAVE_LIBYAJL)
 yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
                                 libxl_cpuid_policy_list *pcpuid)
 {
     return 0;
 }
+#endif

 int libxl__cpuid_policy_list_parse_json(libxl__gc *gc,
                                         const libxl__json_object *o,
--
2.51.1

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.