[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 09/24] xen/domctl: wrap vcpu_affinity_domctl() with CONFIG_MGMT_HYPERCALLS


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Fri, 21 Nov 2025 18:57:46 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ujDe1zt9QHrXlG7ZNmi2RWPU8HuKyDN6Q+EP1SD7HV8=; b=A90AZw0ITXUe5iH1c/cvR9CsOtGrqzefMgDb8VFVsBN0nHswsW1CNGDS5ARkl0ATbNxSdaJuQggeH4n6x+B2Q0J+lP9VHEs3Jclq4LAV1lrUvFOZjnpUwtfegx2+2Zy/vZIG7IgXhBsGuOAk/EeLdG6fCSTxxwQiVutWr7JU78KqFw4mXZqMiw7TUcGaxxO5SKXK0q3jy/js0DnZUBeWAU2ARoKvurS7zmykvCVuqbjH/0ZzasxjE8pD0CCrbwn1zNr7T5HSJDc/EXEwyvuyfYYfFKjd2A0pWy1g3Nz8cXGyFEPqm4PJMnIF/uP+7dbW0sRvkvFJUp2qurQTo80GMg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ke9yDmteeYhVKq/N6zQDOQkMwa/lKkcNa3u8t2t8LYuNdoqSDMiX2DcU6vsMUkkwFY8H4eu28kQjb9Xxd+M9w1l5vwS/EZXXDFy7RxZ/OvUqNToRdTSWWu4Q/rfurput33a5y8Lex84ORz6OaxbdhH6GP4Lsi9TugEKR2GFBsVd1feDsu27y6jx/h5m8nQ+O+2XHp5yhh5Dtnf8TG2Jm+sxtlh/5XXTFpuT3fTjaqCJQvZ6PtDUObe1FqcsSzcf7L4UAb3kq6KRpkffEZNSCoZiLJxYayM7gkh0FvE4jMNdcuVFIdDkIjlojgkET3nyWGX4xHa83ECaIImLsnOR4kQ==
  • Cc: <ray.huang@xxxxxxx>, <grygorii_strashko@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>
  • Delivery-date: Fri, 21 Nov 2025 11:01:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Function vcpu_affinity_domctl() is responsible for
XEN_DOMCTL_{getvcpuaffinity,setvcpuaffinity} domctl-op, and shall be
wrapped with CONFIG_MGMT_HYPERCALLS. Otherwise it will become unreachable
codes when MGMT_HYPERCALLS=n, and hence violating Misra rule 2.1.
Tracking its calling chain, vcpuaffinity_params_invalid() also needs
wrapping too

Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
---
v1 -> v2:
- adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS"
- wrap XEN_DOMCTL_{getvcpuaffinity,setvcpuaffinity}-case transiently
---
v2 -> v3:
- adapt to changes of "remove vcpu_set_soft_affinity()"
- address "violating Misra rule 2.1" in commit message
- remove transient wrapping around 
XEN_DOMCTL_{getvcpuaffinity,setvcpuaffinity}-case
---
v3 -> v4
- wrap vcpuaffinity_params_invalid()
---
 xen/common/sched/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 88150432c3..83e34e7c05 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1678,6 +1678,7 @@ int vcpu_temporary_affinity(struct vcpu *v, unsigned int 
cpu, uint8_t reason)
     return ret;
 }
 
+#ifdef CONFIG_MGMT_HYPERCALLS
 static inline
 int vcpuaffinity_params_invalid(const struct xen_domctl_vcpuaffinity *vcpuaff)
 {
@@ -1798,6 +1799,7 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd,
 
     return ret;
 }
+#endif /* CONFIG_MGMT_HYPERCALLS */
 
 bool alloc_affinity_masks(struct affinity_masks *affinity)
 {
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.