[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21 0/6] tools/{lib,}xl: Coverity falllout from the json-c switch
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 15 Oct 2025 18:50:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bp+tPf4BDoHZY94wIdWQ3IwT984ZwcNIl5mPeuyaJt0=; b=uN1Rpp+2aNA0VoxuLTtqQU2TLrG2TiYvLF2nw0ypuryl3dOu+xjPytS2apWHCSls8tfrw3P+mBEF+W+NsNljNrtLpqeg71JKOc2iXUfL/DO1W/mISTYKn6EGZmDYvnaCLMggy+p7NJHCw8+6ciPfdiIv1y5DWm0KDLNa6rX9/33iZN7uroqLNRtKVplu0WODdUsZcdJvOjrLSPyc7FGpNFIhDVkUtfTDneNczUOzoScpTQkDb3J/nS+BLqkLt+tqSp66g0m9BAWNHGrEQXr3K57tt8XlA9CU81tPnkWn0WOmSGFbtVc9XdwQ+tjYMf6GIjTw1hGF+OMoumWaV7cVTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qXaUbP7hIhkIXP/Kl/f0Qv9NODUZDkrO1zCz9TT61NaD7xYW3dvctG/t2keopLHEgTkLdEXgFu+xCLfFsjh7eydOQ6j+EMRS8rAgzu/DTNWGtzuzjDVWvjakIrj2untAkfc583QSJYvJEaRaStrcDbAW0mu5ffwaXBWDAFTCXAPFPrZtv4DHPZ4UPwUlRRI0QncmFgqKnTZBik1lbqXwvvNUhqIRcb6zWxGlEalhyBT5PnIdY3ZMjAd9t0sy5bcoUYaB5TQcs5wleVntWzdHTGuJ6xHWytnl3DnQTNcuDNdx8uREZ8u8EDl2uu+KboqJSiChts/MwZtqJdVGA76BnA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, oleksii.kurochko@xxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 15 Oct 2025 16:51:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Oct 15, 2025 at 04:04:06PM +0100, Andrew Cooper wrote:
> On 15/10/2025 2:40 pm, Roger Pau Monne wrote:
> > Hello,
> >
> > The following series contains fixes for Coverity reported issues after
> > the switch from YAJL to json-c. Those reports are from the internal
> > XenServer Coverity instance, as the project one hasn't been switched to
> > use json-c yet, last patch in the series switches thegithub triggered
> > Coverity build to use json-c.
> >
> > All should be considered for 4.21.
> >
> > Thanks, Roger.
> >
> > Roger Pau Monne (6):
> > tools/{lib,}xl: fix usage of error return from
> > json_tokener_parse_verbose()
> > tools/libxl: avoid freeing stack rubble in
> > libxl__json_object_to_json()
> > tools/xl: check return of json_object_object_add()
> > tools/xl: check return value of printf_info_one_json() in
> > list_domains_details()
> > tools/xl: fix possible uninitialized usage in printf_info()
> > github/coverity: switch to building with json-c instead of yajl
>
> Other than my query on patch 1, everything else LGTM.
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks, if no one else expresses an opinion by tomorrow I will apply
your comment and commit.
Roger.
|
