[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 24/26] xen/domctl: wrap arch-specific domctl-op with CONFIG_MGMT_HYPERCALLS
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Mon, 13 Oct 2025 07:18:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x67xncueDdaEEto0kiXfl9pIIjowX4FydOBFE2Kh0mY=; b=Pqf2CMg1kwiGOGSUr9KlUcoCsRZNFiSlGTbD8Z3HENyguqJGu41RFO1oMmb9RgIl2lVS03bDwRuEOAawrhu5A9JYoWof+XHwKNurk02z69jxMhJvPEQum+KzDh8zyEZiVRcTE3cb2S1DANeKi5jHtbILE/vIWUOqZ3KdrbwSxv+no2ipz7z52tIPv8xxze5mR653rH6rUqINbpTUWk61cnXsIFG25jk9Q1ZN+IECjnW0+iOJoWi53F2+sSIC1DXmrpgplxmeQ+RMSGlWAM3MLomt54TynOuOwphUYlSgthyKQO81rcEweZCDfAMKGIHdQXJtIX3haNJegQ1OXO5ezA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bx5THhAG/B4Wnd/Q0dM336yqxDa66CNJrhbMgwCNSepePBD3LrMqOY4iWxpT0DoXlLw3fTuBtyyMVE5lBVPqbNEn6CzFZ9+EzyIUBgQwXddeSpuMvay5y7gxY3QZxgIb1IsPaSe0UtikqwXHGu79y2ggQqHuWchXfW03vY+aUzeqhEfMm591s7gu7yAfimyarmAJtKIE/x+vd5vyte24RGgHfyoI2sAP8qF8vBZwRagtHbYjXVKE+5yyVIxTX/LM4sNoPsUR14Y0Z2cnKxjpSr70+fJartVenREmihlj/cTM3KCwuNplmhiSTYNy5/0cyVFN4Lf/m2rZZcVZjCF9qA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 13 Oct 2025 07:18:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-10-13T07:18:24.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcIiYjKV/PcPIAQEuJ6TZ/Q8rQNrSN9F6AgC6RCYCAA08OAIAABX1Q
- Thread-topic: [PATCH v2 24/26] xen/domctl: wrap arch-specific domctl-op with CONFIG_MGMT_HYPERCALLS
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Monday, October 13, 2025 2:41 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>;
> Orzel, Michal <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Roger Pau
> Monné <roger.pau@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>;
> Bertrand Marquis <bertrand.marquis@xxxxxxx>; Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>; Tamas K Lengyel <tamas@xxxxxxxxxxxxx>;
> Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 24/26] xen/domctl: wrap arch-specific domctl-op with
> CONFIG_MGMT_HYPERCALLS
>
> On 11.10.2025 08:44, Penny, Zheng wrote:
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: Thursday, September 11, 2025 9:03 PM
> >>
> >>> --- a/xen/lib/x86/Makefile
> >>> +++ b/xen/lib/x86/Makefile
> >>> @@ -1,3 +1,3 @@
> >>> obj-y += cpuid.o
> >>> obj-y += msr.o
> >>> -obj-y += policy.o
> >>> +obj-$(CONFIG_MGMT_HYPERCALLS) += policy.o
> >>
> >> Fair parts of cpuid.c also become unreachable. And all of msr.c afaics.
> >>
> >
> > I just found that the functions defined here, as helpers/libraries, are
> > used in
> tools/libs/guest/xg_cpuid_x86.c too. Emmm, to make compiler happy, I still
> need to
> provide stubs for them when MGMT_HYPERCALLS=n. Or any better suggestion?
>
> How does the Makefile change here affect tools/libs/guest/? What would you
> need
> stubs for there?
>
Like Function xc_cpu_policy_is_compatible() in tools/libs/guest/xg_cpuid_x86.c
is also using x86_cpu_policies_are_compatible() to do the comparison between
host and guest. If making xen/lib/x86/plocy.o guarded by MGMT_HYPERCALLS, we
will have "undefined reference " error. Imo, it is not suitable to guard files
tools/libs/guest/xg_cpuid_x86.o with MGMT_HYPERCALLS.
So it we still want to have the Makefile change here, we need to provide stubs.
Or we remove the Makefile change here, as the role of these functions is more
of the library,
> Jan
|
