[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 2/5] arm/gic: Use static irqaction
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Fri, 10 Oct 2025 09:21:52 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zlXSCVZNOtMQP9ErfahZxj1Ps5OJW5O34DJ583T2U3A=; b=hK9sZP6gGXh+r5aZ1+QM+p9ToVz9QEpv1kU5Gm1R4gG1PufsKhelzyVA/oTcN8HvV4m9nShmvwTZaaLhe3ArVcgD8wI+Fh7mzrq1BlonODxyjZwOBq8zCe2N+cLziUmt+mOfbY6l4h5wFcdSqHbglLjdxW6tv5gH1mMWqwexQSRI56v1hqlU/A7Qzlc+f/8k8ibWjP5KMcQ47aoUy8t8pAkd0SdUfyvpjqX1VupzD/Fsaa/JysLU2n/B3/UG6sqraxEf+t45HML0zBYkn0LP6YfyShx0GrsGfj8pyhpO+WgutXcVJ3O/0BN69TT1Upt0e71HnHtGAmx59pjVhtOCeA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lY4MWScfae81zsxZz9Tpb+N5Sb+okoScGzo3tJYbgB7fwDiWgWOK/AQjopFzykROGwvaM7C0iUg55Dzhqhk0NRAdLnUQSUS7OIZG/TRprF3t0eirVBD9j9FOVGnGUxbQaVSX764xSQvjvXyyX/rjRcDOkzlJtHRDKDxSnbpbTDDt954cg7MoWdij3FO3Z7FJpXYe5f7tdz90hwFOJYHj4MbYq0oLIotSO8tYSQAu/zaEp8DSUj1ejBb9gY8elBDvImAQiH3S49N1JIvmXrqNiliXtZvrWx8fZRLk2cCb4WjbR/xXMHitS0JrhtRupju4rchDlEEakRxCH+D1a44bkQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 10 Oct 2025 09:22:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcOcdQEP4hwhLsJ0CWMbVHN1hrFw==
- Thread-topic: [PATCH v3 2/5] arm/gic: Use static irqaction
When stopping a core cpu_gic_callback is called in non-alloc
context, which causes xfree in release_irq to fail an assert.
To fix this, switch to a statically allocated irqaction that does not
need to be freed in release_irq.
Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
v2->v3:
* no changes
v1->v2:
* use percpu actions
---
xen/arch/arm/gic.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 260ee64cca..ed6853bb32 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -386,10 +386,17 @@ void gic_dump_info(struct vcpu *v)
gic_hw_ops->dump_state(v);
}
+DEFINE_PER_CPU_READ_MOSTLY(struct irqaction, irq_maintenance);
+
void init_maintenance_interrupt(void)
{
- request_irq(gic_hw_ops->info->maintenance_irq, 0, maintenance_interrupt,
- "irq-maintenance", NULL);
+ struct irqaction *maintenance = &this_cpu(irq_maintenance);
+
+ maintenance->name = "irq-maintenance";
+ maintenance->handler = maintenance_interrupt;
+ maintenance->dev_id = NULL;
+ maintenance->free_on_release = 0;
+ setup_irq(gic_hw_ops->info->maintenance_irq, 0, maintenance);
}
int gic_make_hwdom_dt_node(const struct domain *d,
--
2.34.1
|
