[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21] tools/tests: don't pass -E to sed
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 8 Oct 2025 16:30:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b0T/49iL4XtKUCsUuioCjoDjicGoXpBpKyIYChh0SVs=; b=heUSgDrYMDuRgV+7l7GtNaOMSXYYZCkwN6T683S3Cm3sWdTDA8Kr+IIk8/ZuoJQ73qdOb3L3/vUIbUs17BsIpl17LdvL3qnokoz+fdFJZd4dfflhykWdOrO2mme5UKo9PKK00HrbyMGlswTuqESY2sEOHJBBA2qN3sBUwqbflVT9/jpe8X1ySKleXu8VUlkanGfRb50gCG2mEoSYS758+qZgUFu5J/Q157+Jtbdc0nAG/5alSgnGZ+XLi9cvaKcpxYH0oE00Pc5C7Hb+VhY6sE0EpqzbupY3V8awT5wbw6R6cEn3DLXHL5DryFG9+7sllccDp/hN4CxYXON9SAMkHw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tO1906pJCLJCHlwjXwGpVSayICCX4rtYqmbNIBaBMincS3poOf8XoTqrjFtGfKNOXGQf54qtaTRT+j4xwNfZ3gfRvYZPwJFLpQvIdlih6Zp91eaXWsyK+DFGDgmCZ3zNPsGjrhznyBjMDs2UIS7FT+OxK1LLwxFyd4Cv7HQXmq8iMkNzO1G3Fd2TOg9yIeguHOJq2VOXZX6bsZi02+Q/3A1MVPW9r5H8JG2zD9h9E5Wal5ahSebVVHb1EQqghmgXkHrk211aDkA+mcXuuDRr5kLbsv66YEPguABRAU4kEKcHQDYQ23RCVDDW/Q+Y5/0FoqcWxpKA39mTyU9fG0LQ2A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 08 Oct 2025 14:31:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Oct 08, 2025 at 11:47:05AM +0200, Jan Beulich wrote:
> Even the 2018 edition of The Open Group Base Specifications Issue 7 [1]
> doesn't name -E as a standard option; only Issue 8 [2] does. As there's
> nothing "extended" about the expression used, simply drop the -E.
>
> [1] https://pubs.opengroup.org/onlinepubs/9699919799/
> [2] https://pubs.opengroup.org/onlinepubs/9799919799/
>
> Fixes: cb50e4033717 ("test/pdx: add PDX compression unit tests")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I think the -E was carried over from a previous expression, that was
indeed extended.
> ---
> In principle the -e could be dropped too, for being redundant.
>
> Hitting the problem with an older sed pointed out another problem here as
> well: The failed invocation left a 0-byte pdx.h, which upon re-invocation
> of make was (obviously) deemed up-to-date, thus causing the build to fail
> again (until the bad file was actually removed).
Hm, we could do something like:
sed -e '/^#[[:space:]]*include/d' <$< >$@ || $(RM) $@
Thanks, Roger.
|
