[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/26] xen: consolidate CONFIG_VM_EVENT


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
  • Date: Sat, 13 Sep 2025 19:31:53 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757806353; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=H7Z7rEemNPwWDOk4xlNKyvzqspj59iltoaOmQWtea20=; b=dMfoxIlPxxrIVVNA3bof+lUhv7XSjl54picbkzyByJwpKb/POQ0k6D77Upse0w8vrPrnHx92MF2mEzBVbwdvp8utwsGNIdC3uERYkNi0Yh265mVUIsTJae2VJ9wc2l416iRwtylRcGX2aLYY9W2Rbixxdr8a0Kmv4ZaBynbpvBI=
  • Arc-seal: i=1; a=rsa-sha256; t=1757806353; cv=none; d=zohomail.com; s=zohoarc; b=Qz2icy26nm6llYXSsafgH0grImK2yFuKCNY9uvnmXJL3Zj10H30wYXwEnbpRJHV/2zDgC3lVzb2FK1KCzE+N75/aXqaH0aJ8ZON9eNczBlI0z3SFPH1iorQpq4edVzTWaTfCP/o7bAjvz2Wf1eCP3WNepz1ntDKzsaB86D02fMg=
  • Cc: Penny Zheng <Penny.Zheng@xxxxxxx>, ray.huang@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Sat, 13 Sep 2025 23:32:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

> > @@ -99,10 +98,40 @@ long p2m_set_mem_access_multi(struct domain *d,
> >  int p2m_get_mem_access(struct domain *d, gfn_t gfn, xenmem_access_t 
> > *access,
> >                         unsigned int altp2m_idx);
> >
> > -#ifdef CONFIG_VM_EVENT
> >  int mem_access_memop(unsigned long cmd,
> >                       XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg);
> >  #else
> > +static inline bool xenmem_access_to_p2m_access(const struct p2m_domain 
> > *p2m,
> > +                                               xenmem_access_t xaccess,
> > +                                               p2m_access_t *paccess)
> > +{
> > +    return false;
> > +}
>
> So this is needed when VM_EVENT=n and ALTP2M=y. Tamas, is this a configuration
> which makes sense?

Yes, altp2m should be functional without vm_event being enabled. There
could very well be in-guest only use of altp2m via #VE. This function
is used in p2m_init_next_altp2m which means it being stubbed out like
this when vm_event is disabled breaks altp2m.

Tamas



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.