Re: [PATCH v7 02/16] xen/8250-uart: update definitions

[dmukhin@xxxxxxx]

On Wed, Sep 10, 2025 at 11:39:07AM +0300, Mykola Kvach wrote:
> > > +#define UART_IER_MASK \
> > > +    (UART_IER_ERDAI | UART_IER_ETHREI | UART_IER_ELSI | UART_IER_EMSI)
> >
> > Here, aiui, ..._MASK covers all known bits. No #define-s for reserved
> > ones.
> 
> I think we can follow the Linux kernel style here [1]. For example:
> 
> #define UART_IER_ALL_INTR (UART_IER_MSI | \
>         UART_IER_RLSI | \
>         UART_IER_THRI | \
>         UART_IER_RDI)
> 
> This way we avoid using the *_MASK suffix, which could be confusing,
> and clearly indicate that these are all valid interrupt bits.

Agreed, will update.