[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 08/26] xen/domctl: wrap domain_soft_reset() with CONFIG_MGMT_HYPERCALLS
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Fri, 12 Sep 2025 07:18:17 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=va/hHtoVUddBHPPJfrZeDTTi86YAml7MWdPG+2P6Py4=; b=AvKbKKoG53vD33Fb1OT/iX2zLcqS7TEPbPY6Nkfggi4bKKKB/DDGXspfrHAXvn0uvqUmZXhwNAVREz9vbWGfYvKr7bAXXNJw40MfNODJL4iq+Sxgux3fFFyhKx962l3uMpp8DN/R/s6bIUl7eaHMWJQQmm/wVVZiQYRdfvqbVNK55gb6Fa8Xe0o3z3XBVDLwvQlZ3+jhE3GLahmdS+eNdlJYZWEZNa0VkZBjgtD1oahuCUWowzCnwGYROARj30F+zgwMj/58LFH5UVHYu+g7g8gHCtlOhrHs40XbQ9P5sZO0IS2DvSoQkmLnXg+p34xug8qKiIloqPBzjQIuncD0zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a1QmiaRORkcYXR0QrXxZWjJrspdYdxLSk2+lZuHOfOaQ8MgO8VCNsy+kk+KW7Ja2RqG5sSxtsXmm/MvB0i4+JzrTBrqy0Loclf/v9eeBh6WHfBs0hKPikjUsSBbKZDHLDgTLuss7IFqH+fm19YKKze+SKb/U0oG6/hL6hQALbD0pabCtjvF86iRMWvt+LDNgKToj6H45IeqmYJNTYe4NgExQNuaeQSE1Mw+yeWH5SKDa4HSfrNFE+LRjV3jjja26JXxzD2C+N+O8KHBxlHBN2n/akWcNzUSe8srLdFVS9MyBM21R3q0BN5WV6SZ/YpEzQs4uXfmBPgcMCVzl5tfqXA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 12 Sep 2025 07:18:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-09-12T07:18:10.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcIiYHZJOGLvR3zUGWUPGFPkbfXLSMhqOAgAKeg+A=
- Thread-topic: [PATCH v2 08/26] xen/domctl: wrap domain_soft_reset() with CONFIG_MGMT_HYPERCALLS
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, September 10, 2025 11:14 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Bertrand Marquis
> <bertrand.marquis@xxxxxxx>; Orzel, Michal <Michal.Orzel@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>;
> Roger Pau Monné <roger.pau@xxxxxxxxxx>; Christopher Clark
> <christopher.w.clark@xxxxxxxxx>; Daniel P. Smith
> <dpsmith@xxxxxxxxxxxxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 08/26] xen/domctl: wrap domain_soft_reset() with
> CONFIG_MGMT_HYPERCALLS
>
> On 10.09.2025 09:38, Penny Zheng wrote:
> > Function domain_soft_reset() is responsible for domain soft reset
> > domctl-op, and shall be wrapped with CONFIG_MGMT_HYPERCALLS Tracking
> > its calling chain, and the following functions shall also be wrapped
> > with CONFIG_MGMT_HYPERCALLS:
> > - grant_table_warn_active_grants()
> > - argo_soft_reset()
> > - arch_domain_soft_reset()
> > Wrap XEN_DOMCTL_soft_reset-case transiently with
> > CONFIG_MGMT_HYPERCALLS, and it will be removed when introducing
> > CONFIG_MGMT_HYPERCALLS on the common/domctl.c in the last.
> >
> > Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
> > ---
> > v1 -> v2:
> > - remove unnessary wrapping in stub.c
> > - adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS"
> > - wrap XEN_DOMCTL_soft_reset-case transiently
> > ---
> > xen/arch/arm/domain.c | 2 ++
> > xen/arch/x86/domain.c | 2 ++
>
> What about PPC and RISC-V? They have the function in stubs.c, but not adding
> the
> #ifdef there increases the chance that when the stubs are replaced by real
> functions, the intended #ifdef might then be forgotten to add.
>
As we are addressing concerns on the v1 about editing stubs.c files [1], I
removed them all in this patch serie. If they are considered necessary now,
I'll add them back in next version
[1] https://lists.xenproject.org/archives/html/xen-devel/2025-08/msg00135.html
> Jan
|
