[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] efi: Fix line length in init_secure_boot_mode
- To: Gerald Elder-Vass <gerald.elder-vass@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Thu, 11 Sep 2025 18:47:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=cloud.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qyl0XrpajtGk8BJ+o2kIi42BC4riVLLVKAl8oupkkRM=; b=cKXy0T8Wbj1R3DSJqCVaEndJqCooGsdVfJ8QagdC25w2fm35R+MTE6x0yiYzlz6dNIhfTUspuxc9l9LTwMaruOLWcFsh8GEhEQ8tNNupVHQ+7frhvZflmgLDcv1ydDH11Lcw/5xrd3jlG/EErkxyf+cCAsc1lH+nUuH8LM+kKWMijukhYeBNZn0sLQKka4b+6CgpPNcfXN2mgdAm7B3KsvRPzpFZI6zobXKUgxD/xe6ITnmN4m4yPlAMlx4z/iTjgEUN3dBShjsphzmotcWbRVw6PWo3mHaQ5tff3kdmJmTnibECtqCe8hEvRiVZ8ikElxCsginZp/SNHnt/NNdosQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bMwudRTYnfywoBL63X50/xGeCCpnZv//tzghqtzZ9zlSQXU0ZySKwTd0O5lG8PKIETuAqyYgdG+Fk8UVB2+PV2jJqe5L0fCM9QQSbLC+qwKdLYP2+EXmomnmXecM2A9zGXp63KlpxB38AKictGF0W+v/84REieCcXXD+LZOkHCQ32q9mstOpz9qEdJSkPm3F4tACGqBE51Nc0kvYoB94wyR0z/LfIVG0glEQwyNJf9QrkYfGpc2dcx1ws0E46/irqZlMAfd29R0H6YFd2F/b2v/sTHvDMy5Ddagjz/3GgFNFFTflzzQwr1XLEFvhQbXYWlmaapj9h4xPTRzKx7S3rw==
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 11 Sep 2025 16:47:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu Sep 11, 2025 at 10:24 AM CEST, Gerald Elder-Vass wrote:
> Commit cb41b4ce14a9 introduced init_secure_boot_mode but one line was
> not wrapped appropriately.
>
> Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@xxxxxxxxx>
> ---
> CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> CC: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> CC: Michal Orzel <michal.orzel@xxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
> xen/common/efi/boot.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index b86c83d3348c..69fc022c18ab 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -923,7 +923,8 @@ static void __init init_secure_boot_mode(void)
>
> if ( status == EFI_NOT_FOUND ||
> (status == EFI_SUCCESS &&
> - attr == (EFI_VARIABLE_BOOTSERVICE_ACCESS |
> EFI_VARIABLE_RUNTIME_ACCESS) &&
> + attr == (EFI_VARIABLE_BOOTSERVICE_ACCESS |
> + EFI_VARIABLE_RUNTIME_ACCESS) &&
> size == 1 && data == 0) )
> /* Platform does not support Secure Boot or it's disabled. */
> efi_secure_boot = false;
You're not wrong, but it feels a bit excessive having a patch just for this.
Oh, well.
Reviewed-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
Cheers,
Alejandro
|
