[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 1/4] xen/arm: add generic SCI subsystem
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- Date: Wed, 10 Sep 2025 14:49:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KRaxHGvw2BTA0vfQ5YtYv6Ce4yTniHnIe4jQcbb1m2c=; b=TQRtY6Fivz6WYQEnQbeRYkHIhumpEP78l26U/JepveIV7JqT+CFpJfuX+oDsnbccIJyQ8Z6VEZRhwND76LxXJ6jvhu+WaIfp2N2qhbU4Ezzr6cL1NeFufS+UqmdpGea0ov122W+TpuFZHq/4qVLfovkq/bL6v5Zg4WnavBr44t6bHZsB2m7tF+MSOWON67pEW8N18vdMOeCih9QP7/yJ1HcAuSfehktUYsW4O4uLvqqQKVl3UoMJLVkjmNDUxiYigQiQu7GFz4uG2GA/CC+vOH4RTA4ogq1PyLL6HkTn2fhlTjLxarHuVTX/jAQKXv5w6MTnbraF4pHXJhXTtaIYLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HDw+dv+3KAVp9Q6EJlUnS8077pxd20r64ka/2Hni4D4IG+r0zGpAbixmijj9LyDnaGEV+3vgyOb5W7uxRrbwg4K97juhwNQDst6EtnmlDLV4iZ0fCMx7OtNHW8QcR0YECgK2mGDGdVLfOfcF1bzUdvHQiwurGKF/I/164YdWkLb0SkTeTTz0GMBE8k47RRJ5DcU+dXylFqHWdJX1U3WGFH+wJ5ZF4J0amf4qBQS8Fv9Gx1cdAomlqvJEbrGClHjGrA8vsc24ztyU71ejLd48ve/ptlvzymiWcFvDiZuPgdJSpDmEofOitOwXuW9mJrwBMEgQGXS1zmmRwYh6izSqiw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Delivery-date: Wed, 10 Sep 2025 14:49:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcHaczp/pn2jKXU0i48m8PFCAwNLSKpFGAgAHknYA=
- Thread-topic: [PATCH v9 1/4] xen/arm: add generic SCI subsystem
Hi Julien,
Thank you for your observations. You're absolutely right about this.
Currently, the sci_relinquish_resources call doesn't perform any operations
because the single-agent doesn't implement a callback.
I'll move the sci implementation to be positioned above the tee
implementation
and prepare a patch for this change.
--
Oleksii
On 09/09/2025 12:55, Julien Grall wrote:
> Hi Oleksii,
>
> While going through the list of recently committed patches, I noticed
> some changes in the relinquish code.
>
>
> On 04/09/2025 15:21, Oleksii Moisieiev wrote:
>> @@ -1103,6 +1109,10 @@ int domain_relinquish_resources(struct domain *d)
>> ret = relinquish_p2m_mapping(d);
>> if ( ret )
>> return ret;
>
> Style: There is a missing newline.
>
>> + PROGRESS(sci):
>
> I don't quite understand why the sci relinquish was added right in the
> middle of the P2M relinquish logic. At least to me, it makes more
> sense to be closer to TEE (because this is firmware subsystem) and
> possibly even before releasing any devices.
>
> Can you clarify why you chose this placement?
>
> Cheers,
>
|
