[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] powerpc/mm: support nested lazy_mmu sections
- To: Kevin Brodsky <kevin.brodsky@xxxxxxx>
- From: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
- Date: Fri, 5 Sep 2025 17:52:43 +0200
- Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andreas Larsson <andreas@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>, Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ryan Roberts <ryan.roberts@xxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 05 Sep 2025 15:53:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Sep 04, 2025 at 01:57:34PM +0100, Kevin Brodsky wrote:
...
> static inline lazy_mmu_state_t arch_enter_lazy_mmu_mode(void)
> {
> struct ppc64_tlb_batch *batch;
> + int lazy_mmu_nested;
>
> if (radix_enabled())
> return LAZY_MMU_DEFAULT;
> @@ -39,9 +40,14 @@ static inline lazy_mmu_state_t
> arch_enter_lazy_mmu_mode(void)
> */
> preempt_disable();
> batch = this_cpu_ptr(&ppc64_tlb_batch);
> - batch->active = 1;
> + lazy_mmu_nested = batch->active;
>
> - return LAZY_MMU_DEFAULT;
> + if (!lazy_mmu_nested) {
Why not just?
if (!batch->active) {
> + batch->active = 1;
> + return LAZY_MMU_DEFAULT;
> + } else {
> + return LAZY_MMU_NESTED;
> + }
> }
>
> static inline void arch_leave_lazy_mmu_mode(lazy_mmu_state_t state)
> @@ -54,7 +60,10 @@ static inline void
> arch_leave_lazy_mmu_mode(lazy_mmu_state_t state)
>
> if (batch->index)
> __flush_tlb_pending(batch);
> - batch->active = 0;
> +
> + if (state != LAZY_MMU_NESTED)
> + batch->active = 0;
> +
> preempt_enable();
> }
Thanks!
|