[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] xen/arm: split set_domain_type() between arm64/arm32
- To: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Fri, 5 Sep 2025 12:10:52 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zVHrUv1HLYFkWeYJcqq6TRl5KnEXLxpIk0HHERA93jY=; b=YwUBKNrCzRpKpApoa46Xh/jKuwkDY0lpQvutpP0aXsMRuHkY676MZXzCEZEyOb3qMHA7z/BWjX0AihItJd+kUfkq561P9Kq4aGgeg/iwECtRniFmsuzKEF7WPGcXK0BLHiP2vCyu4jEyuGGlb5nKF7m5r4NFho2fd9459mSz6YwKiHyjqgf9tY9hR0DlXJ5aiatBkXCEnx3XJaL2qfcbI2TKqiCaRaM6JSCsW7dlS8jr9hXxwDBEynue/pKEeaEAjbvO2WnP/pdNSoHMYy4W4QK7BaIIHLpDzVNJebtDmjO3LQu59Dht14frvrwZGnQ5YgSpEQPeB/FujIFjHjHtEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sW5Snc4UmwpWJirlP0cuRBw28bi+LqZvfg4RGxBL5hOcFTFz+LhECW0ytZAOE/3qrWezyz8cgsw5RKPVEZAZXq7zvgRoJl0ZYctW+oqy+5/WUziQi2hDdYIGNM1D49cMwgJDiZE0YaIwakKawny09u+wWlJi1pCooUyZKrKI5qUj1up2RzwyxfisFzML+VZka2v+SJ92iFRm7/kdZR+fb3fjDnv1VvB7EdSh3hc3h1BCp7if54LtRxjIVVGGjXrq5NGQapADrvzVNgxQimseJKhXDQPs6Z6qk+epA7y5zhvgL4/NLFoGjZ+02pDKU6vK51ToHn/J5q5+rfLmwLoHbQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 05 Sep 2025 12:10:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcBrdwRN56SCuvyEipomT5fYlVlA==
- Thread-topic: [PATCH v2 1/4] xen/arm: split set_domain_type() between arm64/arm32
Hi Grygorii,
Grygorii Strashko <grygorii_strashko@xxxxxxxx> writes:
> On 27.08.25 03:22, Volodymyr Babchuk wrote:
>> Hi,
>> Grygorii Strashko <grygorii_strashko@xxxxxxxx> writes:
>>
>>> From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
>>>
>>> Split set_domain_type() between Arm64/Arm32 sub-arches as
>>> set_domain_type() implementation is going to be extended for Arm64.
>>>
>>> Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
>>> ---
>>> v2:
>>> - no changes, rebase
>>>
>>> xen/arch/arm/arm32/Makefile | 1 +
>>> xen/arch/arm/arm32/domain-build.c | 22 ++++++++++++++++++++++
>>> xen/arch/arm/arm64/Makefile | 1 +
>>> xen/arch/arm/arm64/domain-build.c | 24 ++++++++++++++++++++++++
>>> xen/arch/arm/dom0less-build.c | 14 --------------
>>> xen/include/xen/dom0less-build.h | 8 ++++++++
>>> 6 files changed, 56 insertions(+), 14 deletions(-)
>>> create mode 100644 xen/arch/arm/arm32/domain-build.c
>>> create mode 100644 xen/arch/arm/arm64/domain-build.c
>> Is it really worth to create two more source files just for one
>> function? Maybe it is better to use already existing
>> xen/arch/arm/arm*/domain.c ?
>
> It seems a common approach used for splitting ARM subarch code.
> code from arch/arm/A.c goes in
> -> arch/arm/arm32/A.c
> -> arch/arm/arm64/A.c
> (just "-" is used vs "_")
Yeah, my point was that both arch/arm/arm32/domain.c and
arch/arm/arm64/domain.c already exists, so you don't have to create a
new files. But this is up to you, actually. I'll be fine with either
approach, just wanted to mentioned that there is another way.
[...]
--
WBR, Volodymyr
|
