Re: [PATCH v4 14/16] block-dma: migrate to dma_map_phys instead of map_page

[Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>]

On 19.08.2025 19:36, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> After introduction of dma_map_phys(), there is no need to convert
> from physical address to struct page in order to map page. So let's
> use it directly.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> ---
>   block/blk-mq-dma.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq-dma.c b/block/blk-mq-dma.c
> index ad283017caef..37e2142be4f7 100644
> --- a/block/blk-mq-dma.c
> +++ b/block/blk-mq-dma.c
> @@ -87,8 +87,8 @@ static bool blk_dma_map_bus(struct blk_dma_iter *iter, 
> struct phys_vec *vec)
>   static bool blk_dma_map_direct(struct request *req, struct device *dma_dev,
>               struct blk_dma_iter *iter, struct phys_vec *vec)
>   {
> -     iter->addr = dma_map_page(dma_dev, phys_to_page(vec->paddr),
> -                     offset_in_page(vec->paddr), vec->len, rq_dma_dir(req));
> +     iter->addr = dma_map_phys(dma_dev, vec->paddr, vec->len,
> +                     rq_dma_dir(req), 0);
>       if (dma_mapping_error(dma_dev, iter->addr)) {
>               iter->status = BLK_STS_RESOURCE;
>               return false;

I wonder where is the corresponding dma_unmap_page() call and its change 
to dma_unmap_phys()...

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland