Re: [XEN PATCH 04/11] tools/configure: Introduce deps on json-c lib for libxl

[Jason Andryuk <jason.andryuk@xxxxxxx>]

On 2025-08-29 09:17, Anthony PERARD wrote:
> On Wed, Aug 27, 2025 at 11:01:59AM -0400, Jason Andryuk wrote:
> > On 2025-08-08 10:55, Anthony PERARD wrote:
> > > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > >
> > > To replace yajl.
> > >
> > > Introduce YAJL_LIBS variable, to be able to remove "-lyajl" later.
> > >
> > > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > Should the two configure changes be merged and placed at the end of the
> > series?  That avoids a half implemented conversion in between.
> It might be half-converted, but it's fully working. Every single patch
> introduce changes that can be use right away. I've actually make use of
> this possibility. On every single patch, we can run ./testidl, which
> will exercise both lib against each other.
>
> ./testidl does LibxlObj-to-JSONstring and back and forth. So on the next
> commit, we would have JSON generated with json-c, which is then parsed
> with YAJL, to finally be generated to JSON with json-c again, then both
> JSON output are compared.
>
> I've actually prepared the patch "libxl: Convert libxl__json_parse() to
> use json-c' last, then put it in front and check that ./testidl was
> still working.
>
> This help me be confident enough that the conversion to json-c was
> correct.
>
> So if we squash both config change, every patch until the config change
> would only introduce dead code.
Oh, I didn't realize that.  Yes, your approach sounds great.

Thanks,
Jason