[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/pvshim: disable PDX compression in PV shim defconfig



On Fri, Aug 29, 2025 at 10:10:59AM +0200, Jan Beulich wrote:
> On 29.08.2025 09:51, Roger Pau Monne wrote:
> > There's no need for PDX compression given the memory map provided by Xen
> > to guests is contiguous, turn off the feature by default in the PV shim
> > defconfig.
> > 
> > Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Fixes: c5c45bcbd6a1 ('pdx: introduce a new compression algorithm based on 
> > region offsets')
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Not sure if a Fixes: tag is really appropriate here. The shim is working as
> is, just carrying code which won't ever be used.

I was borderline also, but I felt it was important to notice that the
change here should ideally had been part of that commit.  Do you have
a recommendation of any other tag I could use for that purpose?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.