[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v8 5/8] xen/cpufreq: get performance policy from governor set via xenpm


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Thu, 28 Aug 2025 18:04:43 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SGXRU6OOlfIx4vW48sL+1I8w8ruvVFPQAhs++IqOvzU=; b=B4VpCPAuVMdg64ShLt3jpMv/BjZgWUN8BxCRUkWzLG/BpH6v/3ZPbnZZLQeCsZXxgGc6hc5PNmFwKFBPn6+G9jiS7r56cByr9QKEbj78jnvJ1+bnbVrrnUtFAvUAcnxxNiTgpYbh5Bb/whLnpE6F/Av0AafIt8Bg9RmPT91dPS8aIWz94GTBhsjb5RNghixxZT3bvsel5/49XrDNkKmUVL8MwGIqIUxGHa9iXmlJql1M0ppNzser9NBSBrJ1lektiikzFIAA8VXp7nlzJmz6LUyvxeaXfBbl1k4OMCrhpgm0tNR93WVNwKNPXYOH5bX18UzK7ERLJ8oFZw3N4Kmtzw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tTuG5AONUt1+xtynw5AhCYGu/WoyI14yUehycG0SjLHyNIUXFcyMRhqmv+pvDzR7+eeTGhPUNDGw4QX7I2J4bx3T9bdLsWaeYyyyYxQeFKaFIQRF67wqgAyRwbVY85brXJOcnfqjxI7+9MzaGrAQKWKxOTcwczTOwXna8HM5hBSBIJdfBTOMZi8taPFp8vW3NtPsFHUhcwhv0g0zv2MXryvvWaWQlVlQ5hPJKuWln9O36NqxH20dWhTgVGOQjQyzRAugOPybgyR2NQQsYni60Qhy8AiyBygYCCQI79tLnVyCKmQ1r3M/GJtpCXzZU8L9y9ykLM3tZX2/+az6u8Udcg==
  • Cc: <ray.huang@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Thu, 28 Aug 2025 10:05:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Even if Xen governor is not used in amd-cppc active mode, we could
somehow deduce which performance policy (CPUFREQ_POLICY_xxx) user wants to
apply through which governor they choose, such as:
If user chooses performance governor, they want maximum performance, then
the policy shall be CPUFREQ_POLICY_PERFORMANCE
If user chooses powersave governor, they want the least power consumption,
then the policy shall be CPUFREQ_POLICY_POWERSAVE
Function cpufreq_policy_from_governor() is responsible for above transition,
and it shall be also effective when users setting new governor through xenpm.

Userspace is a forbidden choice, and if users specify such option, we shall
not only give warning message to suggest using "xenpm set-cpufreq-cppc", but
also error out.

Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
---
v4 -> v5:
- new commit
---
v5 -> v6:
- refactor warning message
---
v6 -> v7:
- move policy->policy set where it firstly gets introduced
- refactor commit message
---
v7 -> v8:
- policy transition is only limited in CPPC mode
---
 xen/drivers/acpi/pm-op.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/xen/drivers/acpi/pm-op.c b/xen/drivers/acpi/pm-op.c
index 2f516e62b1..a7eaf29c31 100644
--- a/xen/drivers/acpi/pm-op.c
+++ b/xen/drivers/acpi/pm-op.c
@@ -207,6 +207,17 @@ static int set_cpufreq_gov(struct xen_sysctl_pm_op *op)
     if ( new_policy.governor == NULL )
         return -EINVAL;
 
+    if ( processor_pminfo[op->cpuid]->init & XEN_CPPC_INIT )
+    {
+        new_policy.policy = cpufreq_policy_from_governor(new_policy.governor);
+        if ( new_policy.policy == CPUFREQ_POLICY_UNKNOWN )
+        {
+            printk("Failed to get performance policy from %s, Try \"xenpm 
set-cpufreq-cppc\"\n",
+                   new_policy.governor->name);
+            return -EINVAL;
+        }
+    }
+
     return __cpufreq_set_policy(old_policy, &new_policy);
 }
 
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.