[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] arm/mpu: Implement transient mapping
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Hari Limaye <Hari.Limaye@xxxxxxx>
- Date: Thu, 28 Aug 2025 09:40:19 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n52Ym4k8awErauqtN8zpuL5y/bRLdy0wyKuADI0mL8w=; b=qXi9T52ucw49NUAgB7hhJ9c6RKpHg+Mx+e0EDEhBBspyY/RzOLYdbE0jsbatcHaKPrnSSJuVC7Rv4Oi5Mb2oB0vwaMhB90pgdKvCysYGuZFHDevH0st2aKv1Y9mFvhYTuE0asluXHRfybtPzQDHwrWbh8iN6D/tbszGqzWDHiRXrCkowdYPNEnmh3HSwMfSH1tUCdrFwUcVyf4+pIna3T1LEGCgg35Ab02cif6fuCG9o8FrJvlqqthLgEStiF1lEjOFFXfatOz7gu0MxRXu6HfxNeViCiGq0IJ8GcVKk68EQEBDlMRAgO14f9CsHSdcKjQIrMHYOwc2n0uRYRiGqEQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n52Ym4k8awErauqtN8zpuL5y/bRLdy0wyKuADI0mL8w=; b=SxV2+NjGt10wLC8YDM38NJwpLKgnz8CvBgxOd+2igcE9x3c/OfbyM5Y4ZDb/ZtxQqDHE1gz7Vsqe9K7VP41lHkmHDE1N+XxeaRQYBZjREIYcOqIhFZyFu6EHeZ2NINSVOc+RS2MUrh+a1AxCvP5ASbxbyGcd2T5NUfMXHgUBD3S1qCtQAsRJKjkhF//DT+XjTqeiLlayubCeAQuTZArZkv3jk5MzYU6naQb9x2e4dvM7KWUmSHKXWMObRlmDXUhuzguFw9MlGVIy+WKRnSx8JfuHCOFWrvNPzStPukVi5trgOFDfe6d/K5tCgSuFgagRafPWHUUKRYV+jsv1KN2Eew==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=fSaftOncjEI2DuZ/r0S96IfFvUFmtpMu5H7pGzECS0TivcyAlSpWpCeUOENkajnw1LktDJFSy2LuEPnvf3j4/77eLza6ybUrT3+PYlf76NTtcxM2eoqtuCSoMq9TwRMA8PJj9yT+nWcH6T3SBz9jSiKtIJ4qmvYx8k9g4o8U+E2DtxvJY+y3UUd0mxfM7Cf6J/BTbU9G044jDDZBvSC7H7JPUxk0ePXrru8daiM7Nuz90yWYdAJjgUfaZY4CFIoXEEVXjnHVOINRl27L8b2kAIkb0LYlTrYwUkO0RNAuyUmQjiZCUb8wQqrbEBRdHMMKGVqQOmmU6mTiNuI8TiNRmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a6B1PtggluCRANcGYLZnL73Shfl3pdL0dw0Jq/fcVWXfuiwJtmxqFzvEcqREtkFbO0tczIM6qEv4bQsFm/0WZbqmvhPqOKWqLXTtEM+TZecpdoEIeienA/2aPeacod2l8wrNHcAAKgEY08Pj0CWOOks5S85GH2PxSdQnUeLbXZaKZEqGQeGQCSrbxygibdxU35+jHxzySU8fUCCThOHCGOCWUDPLi3bcBnxhn/2oQT6IJ9OPlYv0vqRaFpPal6YIHXgEjRhG77Dj3nZQP0oHh2xCTh/NHBb4yXAFtJOdTysFC84xNNp+xn3s/D0sycCnyHsiOwFdTgGW+HuuDH3pLA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 28 Aug 2025 09:41:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcF/1H84gXhbGzU0K5yIusBBold7R3z2EA
- Thread-topic: [PATCH v2 3/5] arm/mpu: Implement transient mapping
Hi Michal,
>> +++ b/xen/arch/arm/include/asm/arm32/mpu.h
>> @@ -39,6 +39,8 @@ typedef union {
>> typedef struct {
>> prbar_t prbar;
>> prlar_t prlar;
>> + bool transient;
> Do we expect to have any other flags? If so, it could make sense to use a
> bitfield right away.
Yes, at least one more flag at present - I will update this to use a bitfield
in the next version of the series.
>> #ifdef CONFIG_ARM_64
>> -#define XEN_MPUMAP_ENTRY_SHIFT 0x4 /* 16 byte structure */
>> +#define XEN_MPUMAP_ENTRY_SHIFT 0x5 /* 32 byte structure */
>> +#define XEN_MPUMAP_ENTRY_ZERO_OFFSET 0x10 /* {PRBAR, PRLAR} is 16 bytes
>> */
> To avoid having to update this over and over again, maybe define a macro using
> OFFSET?
>
> Other than that:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> ~Michal
Good point - I will do this in the next version of the series.
Many thanks,
Hari
|
