[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v7 11/13] tools/cpufreq: extract CPPC para from cpufreq para
- To: Anthony PERARD <anthony@xxxxxxxxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Thu, 28 Aug 2025 04:14:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DTV8hKd1XOVU2S4wsTgIXB7xmNSzrtrOxtg4T6Hdxxk=; b=wD1CcrJAa2VVVHdM5pB7lnwI+cKDlsRRs9FpBNpJxBgRlxfhxxa5vJ9MvS+unVNXBWuTg9wO5vZa1G0cr4W9tUZxK46pIcB++8TEKNXIoOSkdlRcgE5lHtYOcYEKcNGXGD3y72C6j9Hfnuzkix6vD/mbv1kJNAg/NdRruDTc9dCen8I0UFWmWbQSIvxUUl48BS8fMVsPvU9TM+NArarPwDTR2w3G+BrIXWKwMow+4KhAhlEKxWitxVOLv3jGD+2SHmN+KNyhlR4CFGtJ7cZbO/Dl1IlE7l9CU5X4dxpYi9OlYiPw1lMswbryfgaDfs2mEg22YdvTFQRTI8fU+dCAHg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YsqaW92NgQPi3Gn2DAymV+3WrODTtrpZzNW7XCtxPd/GO1dzXDwr/yP1qyR54Tr6PvdwzWn4aEmTP6dgSzd52CZHz03o95xnfPykrJGmIhf+PD+8QC9OM+IP2PWRLShJuCx+waEThOtucpJFiOIIetGO0cTF9cArCsgWo3NF7emNf9vAD53fdsWQBl1sP+uhGnhOFp7lq1onOBRkE+GxK3OHAmevNjuokbAShMIKf5SMDocdieijqU7Pojr8wdvF0km08Cn5AOC5IKQd7xgd/FzA2RtuUrIjWRMBHLnWRqkj6GrJ4oaAKCTsnhKl07P3gXr7NrkpE9jBLYYOKfRBhw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 28 Aug 2025 04:14:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-08-28T04:13:06.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcE1LyQ0lYyaNtv02FRdV+NHpcFrR2pieAgADXRwA=
- Thread-topic: [PATCH v7 11/13] tools/cpufreq: extract CPPC para from cpufreq para
[Public]
> -----Original Message-----
> From: Anthony PERARD <anthony@xxxxxxxxxxxxxx>
> Sent: Wednesday, August 27, 2025 11:22 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Huang, Ray <Ray.Huang@xxxxxxx>; Anthony
> PERARD <anthony.perard@xxxxxxxxxx>; Juergen Gross <jgross@xxxxxxxx>;
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Orzel, Michal
> <Michal.Orzel@xxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>; Julien Grall
> <julien@xxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>
> Subject: Re: [PATCH v7 11/13] tools/cpufreq: extract CPPC para from cpufreq
> para
>
> On Fri, Aug 22, 2025 at 06:52:16PM +0800, Penny Zheng wrote:
> > diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index
> > 6b054b10a4..8fc1d7cc65 100644
> > --- a/tools/misc/xenpm.c
> > +++ b/tools/misc/xenpm.c
> > @@ -898,6 +900,23 @@ static void print_cpufreq_para(int cpuid, struct
> xc_get_cpufreq_para *p_cpufreq)
> > printf("\n");
> > }
> >
> > +/* show cpu cppc parameters information on CPU cpuid */ static int
> > +show_cppc_para_by_cpuid(xc_interface *xc_handle, unsigned int cpuid)
> > +{
> > + int ret;
> > + xc_cppc_para_t cppc_para;
> > +
> > + ret = xc_get_cppc_para(xc_handle, cpuid, &cppc_para);
> > + if ( !ret )
> > + print_cppc_para(cpuid, &cppc_para);
> > + else if ( errno == ENODEV )
> > + ret = 0; /* Ignore unsupported platform */
> > + else
> > + fprintf(stderr, "[CPU%u] failed to get cppc parameter\n",
> > + cpuid);
>
> You might want to add ": %s" strerror(errno) to the error printed, which
> could help
> figure out why we failed to get the parameters.
>
Ack
>
> The rest of the tool side of the patch, with Jan suggestion, looks good to
> me, so
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> for the next round.
>
Thanks
> Thanks,
>
> --
> Anthony PERARD
|
