[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: respect unset video_memkb for Dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 27 Aug 2025 21:12:50 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CeWl4L1ejDYaQX9EACJn7a7RUgsq2qYn/ZrHYswGs54=; b=n4TRHhw7EpAb1M1CmST20euyhqK2toPTaae9wKos84iK7DptDwwr8NZ0wRnBhZbbFOPK+nnidGQNEXqUHmF8v/BdKQPhcBNHgIH/SFuLn59JiIDHlae+0HhvVjCpkswDNQ6f+ipTADrL1d1euut7kmjqBR4AEPZuZaLSNgC5cOw+9KpqlWDxhgz3X7tsmzV9blA5je6D1S6H4q7o+O+USsuJwuV1W1D7M64j8zcKDir2M7QJst2Z5Q3FDWK59CZ08Agk4244cvXx+n2bheN1bcdCZ/DJAZzRlft2KtuyIO7djKwwQ/BW2P9FzbPseSECO2d6i1RdJtBGJsxvGOx0/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c0xjUS8eveNKkceKVgUl04PTh24OPfVtIvTW/ST7T4GqVpfgRlReiRyKPvNvprethTQsb7gXmXDpfn+hxFcm0yPgDCBhSuPmzB/NkpkxlbzfOy1lLaodMDfFDMA/sfPHmL08dSEq7xHGp6X5uot3xc/EmIFCkq8TfQY1e97ArOh0mSFOMOICGcuuRbEf+H+lIIco7/Ns0WW9W2fU6gNNp2BC+zaMPxnl6U+9CmwgYM1iIDuS+hdMQfKn52L9xC1FcHddEEhX2GenM8LDcVsJ0Qla5eYO1fFOSC7HXjWg9ju7ou1bzs70+DiZD5rUdkV7+muSTVC0Zo7egEIiY2k2WA==
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Thu, 28 Aug 2025 01:13:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-08-27 01:56, Jan Beulich wrote:
Without this, Dom0 will have have a curiously off-by-1 target_memkb
value displayed by "xl list -l".
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
In theory, b_info->video_memkb should have been defaulted to 0. In
practice you found it isn't. xen-init-dom0 could probably use some fixing.
---
In retrieve_domain_configuration_end(), isn't it the wrong way round to
set both ->b_info.target_memkb and ->b_info.max_memkb only after calling
libxl__get_targetmem_fudge(), when that uses the two fields? This way we
could as well use ->b_info->video_memkb directly there.
I think it's attempting to read the current values from xenstore, in
case they changed via xl mem-set, and then putting them into the d_config.
Regards,
Jason
Of course this may point at a bigger problem, as other fields may
similarly never be set for Dom0.
|
