Re: [PATCH v3 06/11] powerpc/ptdump: rename "struct pgtable_level" to "struct ptdump_pglevel"

[David Hildenbrand <david@xxxxxxxxxx>]

On 26.08.25 18:28, Ritesh Harjani (IBM) wrote:
> David Hildenbrand <david@xxxxxxxxxx> writes:
>
> > We want to make use of "pgtable_level" for an enum in core-mm. Other
> > architectures seem to call "struct pgtable_level" either:
> > * "struct pg_level" when not exposed in a header (riscv, arm)
> > * "struct ptdump_pg_level" when expose in a header (arm64)
> >
> > So let's follow what arm64 does.
> >
> > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> > ---
> >   arch/powerpc/mm/ptdump/8xx.c      | 2 +-
> >   arch/powerpc/mm/ptdump/book3s64.c | 2 +-
> >   arch/powerpc/mm/ptdump/ptdump.h   | 4 ++--
> >   arch/powerpc/mm/ptdump/shared.c   | 2 +-
> >   4 files changed, 5 insertions(+), 5 deletions(-)
>
> As mentioned in commit msg mostly a mechanical change to convert
> "struct pgtable_level" to "struct ptdump_pg_level" for aforementioned purpose..
>
> The patch looks ok and compiles fine on my book3s64 and ppc32 platform.
>
> I think we should fix the subject line.. s/ptdump_pglevel/ptdump_pg_level
Ahh, yes thanks.

@Andrew, can you fix that up?

> Otherwise the changes looks good to me. So please feel free to add -
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>
Thanks!

--
Cheers

David / dhildenb