[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] xen/arm64: constify is_32/64bit_domain() macro for CONFIG_ARM64_AARCH32=n


  • To: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Wed, 27 Aug 2025 00:19:07 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yr71aB/kHUl+qZczs297RTTR6ScXudXbw0EeAD+Ve3E=; b=xAJHg4yOsJjRmF/U6MmqqR4R4AErIqM0DfOqiHZsTkXPqBZURieJG/+ATg0EUnUNzGzZVTtn4IJ3H8OCK2d22koDLFposA8wQWWZsmcO6enlPiuGwzftIEwXNzKEAqyUHv4L5klJuL2SeqS23U4j8yOfBKDBX5Zy9ix69YFXqisg0mNrTfWtkw1InNaKPNi0B9RGDJ6c7Prl5ny+WJ1PN+IdSacSkDnd8sUjb5NyZl3xpMUWzcpvX834eIk+cqxkTA4FO394dlIyEJnSb3FGzRovsQGzGS/vZoyfa3giwPJDDvZc1quO0JKQbjFTXLHuiu70EtByT4DmR8q+2UuyWA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gtRECZ9vkvHeDB3W3PM6lO9H5Alz1leZ2NIPDSYsOOIkgLdthz/u3CehDbUZb22Axo7h9cJ93ZZLhGa/whV/0bNolQui9KSjoJpvWr77VLAOasSrXQK3zcPqKLKBKeqOt0L07Re9mifZlp6NC/gEI0YQRJE+kv2h3k/9Q5UymBY8Bp0jhCxXLrYTD46jlJrO5DoQC2TTaRnlo9qiOQU56oRCFPCrIj12ozpTRq8+k9rfmHA9eTuol/+J3leaAQBloLQtviULmbRfymlj3gW79byFKtnP6GtZgUZlK617whcR7C7LXF6tOQv29e3vQcQQJawAn7FnrS7dMyN+vzZ7kg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
  • Delivery-date: Wed, 27 Aug 2025 00:19:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcBrdwDd4mYDTTDkqkhQfu8XlSDA==
  • Thread-topic: [PATCH v2 4/4] xen/arm64: constify is_32/64bit_domain() macro for CONFIG_ARM64_AARCH32=n


Hi,

Grygorii Strashko <grygorii_strashko@xxxxxxxx> writes:

> From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
>
> Constify is_32/64bit_domain() macro for the case CONFIG_ARM64_AARCH32=n and
> so allow compiler to opt out Aarch32 specific code.
>
> Before (CONFIG_ARM64_AARCH32=y):
>    text          data     bss     dec     hex filename
>  859212        322404  270880 1452496  1629d0 xen-syms-before
>
> After (CONFIG_ARM64_AARCH32=n):
>    text          data     bss     dec     hex filename
>  851256        322404  270880 1444540  160abc xen-syms-after
>
> Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

> ---
> v2:
> - use IS_ENABLED(CONFIG_ARM64_AARCH32) instead of ifdefs
>
>  xen/arch/arm/include/asm/arm64/domain.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/include/asm/arm64/domain.h 
> b/xen/arch/arm/include/asm/arm64/domain.h
> index bebcbc582f97..70dfbeac7443 100644
> --- a/xen/arch/arm/include/asm/arm64/domain.h
> +++ b/xen/arch/arm/include/asm/arm64/domain.h
> @@ -12,14 +12,16 @@ struct kernel_info;
>   *
>   * @d: pointer to the domain structure
>   */
> -#define is_32bit_domain(d) ((d)->arch.type == DOMAIN_32BIT)
> +#define is_32bit_domain(d)                                                   
>   \
> +        (IS_ENABLED(CONFIG_ARM64_AARCH32) && (d)->arch.type == DOMAIN_32BIT)
>  
>  /*
>   * Returns true if guest execution state is AArch64
>   *
>   * @d: pointer to the domain structure
>   */
> -#define is_64bit_domain(d) ((d)->arch.type == DOMAIN_64BIT)
> +#define is_64bit_domain(d)                                                   
>   \
> +        (!IS_ENABLED(CONFIG_ARM64_AARCH32) || (d)->arch.type == DOMAIN_64BIT)
>  
>  /*
>   * Arm64 declares AArch32 (32bit) Execution State support in the

-- 
WBR, Volodymyr


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.