[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v9 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests
Hi Mykola, On 26/08/2025 10:09, Mykola Kvach wrote: Shouldn't this be removed so the check also apply for 32-bit domain on 64-bit system?AFAIK, this question was already addressed in a previous version of this patch series: https://patchew.org/Xen/cover.1751020456.git.mykola._5Fkvach@xxxxxxxx/072270e0940b6bcc2743d56a336363f4719ba60a.1751020456.git.mykola._5Fkvach@xxxxxxxx/#7070f416-119c-49f8-acd0-82c6e31f0fc6@xxxxxxx Sure. For 32-bit domain, in theory the top bits should be zeroed. But AFAIK, there is no harm to zero them again and it would avoid someone to wonder why this is protected by is_64bit_domain(). So unless there is a strong reason to keep, I would rather prefer if we remove the 64-bit. Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |