[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] Arm: drop assertion from page_is_ram_type()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 25 Aug 2025 13:48:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r+2vB9Yh8cZsFhuuyXYV/KJRQJbXQx2ZP0o4Ye/uVsQ=; b=WFB/YKbizlGUfnkmR091c6T2L01FFf1DsK/XKgT3kvhjqLUp5SWKCYyFdN8/SCEcIXPMaTA89kLYN9F+Lp0MhlBUWVmjINbLs5KAycBtcyjViU0P9T4JOvuMQDxiCgvj2eO3vBwYy+QKffW1WwrGMFb97ZurjIsHBgDtVxmkYt+wa8AfR1POYuUUbaZ4dfZjFEpzEiSlmAGYixu78sZuyaMI0UVlMOd6gjPQaEsEYYPBwtdGUqVAz8xrlmmlravTBpTwSA6HqvdWZJH3R2jxoB/Im3tBrlJiAjNDI4p2oLrssnNWT9lFeYOg5euVVdy0Ih0nqcHewZah5SNdHOqJLA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lD/LJE206aQRBGmdDDs29KNR2qNB154/Si9n54Gs1crV+SejJWt+t4u+46INiCPzx9ECayCZL/a3w+RnG3zLjmgCkwF5l7Tn6UTeB0Mlj6oayZ8LHlcvynZmRGfgIgxrJ4/vtGzk3wAIY5VYsHJIAzbR2SL+PloYNKPl7Vr0dDSUXz/SPfj2M5HMzXkSlz8Fk8846jPIQmsKFRWRuQa92/JrTFzK/59ujpudmzjyFRoFzSZhTu6N/jPdjr0pO1aJELSHmU+R5WMOTYbydfm0d0AmJWwdBkCvuRSclPP3iINwrUt2IOD6Q0qAQti+VEGQBm3Nf2hVZZ2X1/5LE086bw==
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 25 Aug 2025 11:48:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/08/2025 09:55, Jan Beulich wrote:
> Its uses in offline_page() and query_page_offline() make it reachable on
> Arm, as long as XEN_SYSCTL_page_offline_op doesn't have any Arm-specific
> code added. It being reachable was even mentioned in the commit
> introducing it, claiming it "clearly shouldn't be called on ARM just
> yet".
>
> However, dropping the assertion from a function of this name is deemed
> problematic. Rename it to better reflect its sole purpose outside of
> x86-specific code.
>
> Fixes: 214c4cd94a80 ("xen: arm: stub page_is_ram_type")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
