Re: [PATCH v5 3/4] hvmloader: add new SMBIOS tables (7, 8, 9, 26, 27, 28)

["Teddy Astie" <teddy.astie@xxxxxxxxxx>]

Hello,

Le 24/08/2025 à 00:29, Petr Beneš a écrit :
> +/* Type 7 -- Cache Information */
> +static void *
> +smbios_type_7_init(void *start)
> +{
> +    /* Specification says Type 7 table has length of 13h for v2.1+. */
> +    BUILD_BUG_ON(sizeof(struct smbios_type_7) != 19);
> +

I would prefer having hex constants (so that it matches the number
format the specification gives).

e.g
BUILD_BUG_ON(sizeof(struct smbios_type_7) != 0x13);

(same for other checks)

Teddy


Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech