[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] common/efi: fix Rule 2.1 violation in read_file()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Mon, 25 Aug 2025 10:28:18 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Nasimg8iyCoY7CKQsSbDDr6b2t1xiKW6YB3aXxqx6A=; b=MgEz+UhcfMqb5vlUZVeFHMLYlMe4w2tAzGr6To7MMQ2l3yQxGfV41cdeMYyv9Zh61actroXP+KJOnhwgNEylCwVBaAPnbauxfsMpcL8z9Sd+ChhBE0ZbyMEZryDKwX+IwxYV/sC7um5ZR4KF6RolFW7ERTiXLs3ZrRiOgiEdQ4txABRvkdlevYq9kZijv4gFCZ7gas2IoGS3fvszm/FrISqbdQRx6swkB0tHc5ivM8nhszpmDD8S1pPuiz7IE8GvFkK+9sGE36ic6bhcnGOtl65ZCBYG5qlozq0Azue0WXXuGgIf3MiMygPnQYFQ00rcNQFZOgro42Oshzlc0J5E8g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XgyppLFynmuFQgjxStk7P1V7c/udnDAUo5T17mGKmiu6b4iFTm2iRgGZWbmAOBABVnrNHr9tbuKA1RCTrj7JwccU/Ln1NvDhX/UEUxlElc+Es95tGAkMqnd1uWmmqrRVRnmwI+cGMRSZ7knODTWehcyg/WAtIyzuKqR4PiycZ2NWsITQkOK0n41w576o3AIjZLLA0zZcUWBVIxOe9pMDzaPGyqmVSn63K1pB9Rp7SLr+zv9EzQDTj6APF2ebYjgAKwDczz9Dj27ADtR3ezZ1I46N28zNsg217UGyi29egGgERH5KE6BDoo2Scg74ZrwyCt//cMMF3X7PwQGbh4JcNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 25 Aug 2025 10:28:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcFQlF20ah2tP5uUOdXQ1Ea/l407RzJ1sAgAAEg4A=
- Thread-topic: [PATCH v4] common/efi: fix Rule 2.1 violation in read_file()
On 8/25/25 13:12, Jan Beulich wrote:
> On 24.08.2025 17:10, Dmytro Prokopchuk1 wrote:
>> MISRA C Rule 2.1 states: "A project shall not contain unreachable code."
>>
>> The return statements in the 'read_file()' function is unreachable due
>
> Especially due to the (imo wrong) use of plural, this continues to be
> ambiguous. I'd suggest switching to singular and inserting "final" or
> "main". Happy to adjust while committing, provided you agree.
>
> Jan
I don't mind.
Thank you.
Dmytro.
|
