Re: [PATCH] xen/arm: irq: add missing spin_unlock() in init_local_irq_data() error path

[Mykola Kvach <xakep.amatop@xxxxxxxxx>]

On Mon, Aug 11, 2025 at 10:53 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 09.08.2025 16:32, Mykola Kvach wrote:
> > From: Mykola Kvach <mykola_kvach@xxxxxxxx>
> >
> > If init_one_irq_desc() fails, init_local_irq_data() returns without
> > releasing local_irqs_type_lock, leading to a possible deadlock.
> >
> > Release the lock before returning to ensure proper cleanup.
> >
> > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> Pretty likely wants backporting, which would best be indicated by a suitable
> Fixes: tag.

I have added the Fixes: tag as suggested and resent the patch.
Thank you for pointing this out.

>
> Jan
>
> > --- a/xen/arch/arm/irq.c
> > +++ b/xen/arch/arm/irq.c
> > @@ -94,7 +94,10 @@ static int init_local_irq_data(unsigned int cpu)
> >          int rc = init_one_irq_desc(desc);
> >
> >          if ( rc )
> > +        {
> > +            spin_unlock(&local_irqs_type_lock);
> >              return rc;
> > +        }
> >
> >          desc->irq = irq;
> >          desc->action  = NULL;
>

Best regards,
Mykola