Re: [PATCH v1 02/16] arm/vpl011: move DT node parsing to PL011 emulator code

[dmkhn@xxxxxxxxx]

On Wed, Jun 25, 2025 at 08:57:27AM +0200, Orzel, Michal wrote:
> 
> 
> On 24/06/2025 23:56, dmkhn@xxxxxxxxx wrote:
> > On Tue, Jun 24, 2025 at 09:49:39AM +0200, Orzel, Michal wrote:
> >>
> >>
> >> On 24/06/2025 05:55, dmkhn@xxxxxxxxx wrote:
> >>> From: Denis Mukhin <dmukhin@xxxxxxxx>
> >>>
> >>> Move vpl011 DT node parsing from common Arm code to PL011 emulator code.
> >> It's not parsing, it's DT node generation.
> >
> > Oh, that's right, overlooked.
> > Thanks, will update.
> >
> >>
> >> We usually keep all the DT node generation functions in one place. I'm not 
> >> sure
> >> if we want to move them to respective drivers (i.e. vpl011 to vpl011.c, 
> >> gicv3 to
> >> gicv3.c, etc.). Not sure what other maintainers think.
> >>
> >>>
> >>> While doing it pick the generic name vuart_add_fwnode() for DT parser 
> >>> function
> >> What 'fw' stands for? Firmware? This function creates DT node for domU, so 
> >> it
> >> should better be sth like vuart_add_dt_node().
> >
> > 'fw' stands for 'firmware'.
> >
> > It should be some generic name because the function will be used on x86 to
> > generate to generate the guest ACPI tables.
> I see but maybe vuart_add_node() would be a better choice here.

Ack.

> 
> ~Michal
>