[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/3] hvmloader: fix SMBIOS table length checks



On Thu, Jul 31, 2025 at 10:36 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
> With this, the function parameter may better be named "min_size" or 
> "req_size".

Agreed.

> Was this meant to be smbios_type_2?

Wow, that's a nasty typo. The offsets even match. Thanks for catching
that - yes, there should be smbios_type_2.

> The adjustments also look to be isolated enough to carry out while committing.
> Provided of course that you agree with making them.

I agree with the adjustments. Feel free to fold them in while
committing. Thank you.

P.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.