Re: [RFC PATCH v5 03/10] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent

[Anthony PERARD <anthony@xxxxxxxxxxxxxx>]

On Tue, Jul 22, 2025 at 11:41:39AM +0000, Oleksii Moisieiev wrote:
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 4ffcbf624b..68d2ebeb9f 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -1284,6 +1284,36 @@ out:
>      if (rc) exit(EXIT_FAILURE);
>  }
>  
> +static int parse_arm_sci_config(XLU_Config *cfg, libxl_arm_sci *arm_sci,
> +                                const char *str)
> +{
> +    int ret = 0;
> +    char *buf2, *ptr;
> +    char *oparg;
> +
> +    if (NULL == (buf2 = ptr = strdup(str)))
> +        return ERROR_NOMEM;
> +
> +    ptr = strtok(buf2, ",");
> +    while (ptr != NULL)
> +    {
> +        if (MATCH_OPTION("type", ptr, oparg)) {
> +            ret = libxl_arm_sci_type_from_string(oparg, &arm_sci->type);
> +            if (ret) {
> +                fprintf(stderr, "Unknown ARM_SCI type: %s\n", oparg);
> +                ret = ERROR_INVAL;
> +                goto parse_error;
> +            }
> +        }
> +
> +        ptr = strtok(NULL, ",");
> +    }
> +
> +parse_error:

This label could be named "out", as it just a path out of the function,
both on success and error.

> +    free(buf2);
> +    return ret;
> +}
> +

The patch looks fine to me for the toolstack part, so:
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> # tools

TODO on commit (or before): regen golang/xenlight/{helpers,types}.gen.go
due to change in libxl_types.idl.

Thanks,

-- 
Anthony PERARD