Re: [PATCH v11 3/3] xen/domain: update create_dom0() messages

[dmkhn@xxxxxxxxx]

On Tue, Jul 29, 2025 at 10:11:31AM +0200, Jan Beulich wrote:
> On 28.07.2025 20:34, dmkhn@xxxxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > Use %pd for domain identification in error/panic messages in create_dom0().
> 
> Except that ...
> 
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -2081,17 +2081,17 @@ void __init create_dom0(void)
> >
> >      dom0 = domain_create(domid, &dom0_cfg, flags);
> >      if ( IS_ERR(dom0) )
> > -        panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0));
> > +        panic("Error creating d%d (rc = %ld)\n", domid, PTR_ERR(dom0));
> 
> ... here you don't (and can't). To avoid people wondering when they later

Thanks for catching this! Will update.

> come across a commit, I think descriptions would better be accurate. It'll
> be Arm maintainers to judge whether they let you get away with this; as it
> covers x86 only anyway:
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks!

> 
> Jan