Re: [PATCH v1] xen/console: remove __printk_ratelimit()

[dmkhn@xxxxxxxxx]

On Mon, Jul 28, 2025 at 11:32:43AM +0200, Jan Beulich wrote:
> On 26.07.2025 11:20, Julien Grall wrote:
> > On 25/07/2025 22:24, dmkhn@xxxxxxxxx wrote:
> >> From: Denis Mukhin <dmukhin@xxxxxxxx>
> >>
> >> __printk_ratelimit() is never used outside of the console driver.
> >> Remove it from the lib.h and merge with the public printk_ratelimit().
> >
> > Is this solving any sort of violation? Asking because even if the
> > function is only used by one caller, I could see a benefit to be able to
> > use different value for the ratelimit. So I leaning towards keep the
> > code as-is.
> 
> +1
> 
> In fact I'm surprised (or maybe not) that we still don't make better use
> the rate limiting functionality.

Out of curiosity, do you have any ideas re: make better use of the rate
limiting functionality?

Build-time parameterization?

> 
> Jan
>