[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/netfront: Fix TX response spurious interrupts



On Fri, 18 Jul 2025 09:19:17 +0200 Jürgen Groß wrote:
> On 17.07.25 16:29, Jakub Kicinski wrote:
> > On Tue, 15 Jul 2025 16:11:29 +0000 Anthoine Bourgeois wrote:  
> >> Fixes: b27d47950e48 ("xen/netfront: harden netfront against event channel 
> >> storms")  
> > 
> > Not entirely sure who you expect to apply this patch, but if networking
> > then I wouldn't classify this is a fix. The "regression" happened 4
> > years ago. And this patch doesn't seem to be tuning the logic added by
> > the cited commit. I think this is an optimization, -next material, and
> > therefore there should be no Fixes tag here. You can refer to the commit
> > without the tag.  
> 
> I think in the end it is a fix of the initial xen-netfront.c contribution
> (commit 0d160211965b).
> 
> I'm fine to change the Fixes: tag and apply the patch via the Xen tree.

SGTM, FWIW. But I'd like to reiterate my humble recommendation to treat
this as an optimization, and not add the Fixes tag.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.