Re: [PATCH] xen/passthrough: add missing error-report include

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 18/7/25 07:11, Markus Armbruster wrote:
> Adam Williamson <awilliam@xxxxxxxxxx> writes:
>
> > In cfcacba an `error_report` was added to this file, but the
   In commit cfcacbab38e ("xen/passthrough: use gsi to map pirq when
   dom0 is PVH") an `error_report` was added to this file, but the

> > corresponding include of `qemu/error-report.h` was missed. This
> > only becomes apparent when building against Xen 4.20+.
> >
> > Signed-off-by: Adam Williamson <awilliam@xxxxxxxxxx>
> > ---
> >   hw/xen/xen_pt.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
> > index 9d16644d82..006b5b55f2 100644
> > --- a/hw/xen/xen_pt.c
> > +++ b/hw/xen/xen_pt.c
> > @@ -54,6 +54,7 @@
> >   
> >   #include "qemu/osdep.h"
> >   #include "qapi/error.h"
> > +#include "qemu/error-report.h"
> >   #include <sys/ioctl.h>
> >   
> >   #include "hw/pci/pci.h"
> Uh, error-report.h is included without this for me.  To see, build with
> -H:
>
> . /work/armbru/qemu/hw/xen/xen_pt.h
> .. /work/armbru/qemu/include/hw/xen/xen_native.h
> ... /work/armbru/qemu/hw/xen/trace.h
> .... ./trace/trace-hw_xen.h
> ..... /work/armbru/qemu/include/qemu/error-report.h
>
> Code smell: header in include/... includes header from hw/.  Not this
> patch's concern.
Lucky side effect of including "trace.h" a include/ file due to trace
event being called in inlined function. Bad pattern indeed.

Back to this patch:
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>