Re: [PATCH v2 06/17] xen/xsm: Expand XSM_XS_PRIV for untargetable domains

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 16 Jul 2025, Jason Andryuk wrote:
> Untargetable domains are currently hidden from the control domain -
> e.g. xl list will not show them.  getdomaininfo fails on the
> !is_hypercall_target() check in XSM_TARGET.  Add control domain to the
> XSM_XS_PRIV check so it can pass.
> 
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>

XSM_XS_PRIV is only used in XEN_DOMCTL_get_domain_state,
XEN_DOMCTL_getdomaininfo and XEN_SYSCTL_getdomaininfolist, so it makes
sense to me

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>  xen/include/xsm/dummy.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> index f2205575ed..4d7b1d61eb 100644
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -87,7 +87,8 @@ static always_inline int xsm_default_action(
>          fallthrough;
>      case XSM_XS_PRIV:
>          if ( action == XSM_XS_PRIV &&
> -             evaluate_nospec(is_xenstore_domain(src)) )
> +             (evaluate_nospec(is_xenstore_domain(src)) ||
> +              is_control_domain(src)) )
>              return 0;
>          fallthrough;
>      case XSM_DM_PRIV:
> -- 
> 2.50.0
> 
>