Re: [PATCH v2 1/3] hvmloader: clean up SMBIOS code style and formatting

[Jan Beulich <jbeulich@xxxxxxxx>]

On 15.07.2025 00:49, Petr Beneš wrote:
> From: Petr Beneš <w1benny@xxxxxxxxx>
> 
> * Removed trailing whitespaces
> * Removed unnecessary pointer casts
> * Added whitespaces around &&
> * Removed superfluous parentheses
> * Use variables in sizeof() where applicable
> 
> No functional change.
> 
> Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with a few more adjustment, which I may take the liberty to do while
committing:

> @@ -411,12 +411,12 @@ smbios_type_0_init(void *start, const char *xen_version,
>      /* Extended Characteristics: Enable Targeted Content Distribution. */
>      p->characteristics_extension_bytes[1] = 0x04;
>  
> -    p->major_release = (uint8_t) xen_major_version;
> -    p->minor_release = (uint8_t) xen_minor_version;
> +    p->major_release = (uint8_t)xen_major_version;
> +    p->minor_release = (uint8_t)xen_minor_version;

These casts are pointless, too. Since you touch the lines, you could as
well have purged them at the same time.

> @@ -482,21 +482,21 @@ smbios_type_1_init(void *start, const char *xen_version,
>      strcpy((char *)start, s);
>      start += strlen(s) + 1;
>  
> -    uuid_to_string(uuid_str, uuid); 
> +    uuid_to_string(uuid_str, uuid);
>      s = xenstore_read(HVM_XS_SYSTEM_SERIAL_NUMBER, uuid_str);
>      strcpy((char *)start, s);
>      start += strlen(s) + 1;
>  
>      *((uint8_t *)start) = 0;
> -    
> -    return start+1; 
> +
> +    return start+1;

Add the missing blanks here as well while touching the line?

> @@ -920,24 +920,24 @@ smbios_type_22_init(void *start)
>  
>      *((uint8_t *)start) = 0;
>  
> -    return start+1; 
> +    return start+1;

Same here.

Jan