[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] arm/mpu: Populate a new region in Xen MPU mapping table
- To: Hari Limaye <Hari.Limaye@xxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 15 Jul 2025 10:52:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qfr5+Weu4GZHfSxJW43vEPwD8JEb5fSwiBj4tmAvf7k=; b=M7zFRuTtPuwhZa4o4bAnCmKl6swKT5fF5OMZm3+hZsLrqyOunU/SYxuZMBnc0o1Lt0Aj8yR5qbUcPjHP7lc+yMtpLQ+6l3jYzvJfrm/xEUqlG4Zpj65Jdg58xXSZqtcvzTd10p/3EcDHpoE9aMQKUOSSEsUVX0Hd/AbLY1pk/T4qpo879HQGBzz7DbfRsiGHdW90e48KbRP8x6yAeekuvq2KhKRB+IA4ZRlycIJWDm1ySKuSTDs1JVRMqP92zGEgWHzGzKxhR2kGjOHbA8FaoeD8YsEpmbsR6sFYCgvoC+R1tpEc35yJyPc4QkPhH3I7BwPOr+Kvi9mylx4lJWphVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jcFksNX3gGU76KP9UPxHahdG/wwzxHzYnhxO/wLV2tobRwQNGZ7y532W0P5w5wnjxhMP8ap9PqXfa1rI9KPYbWao+LK+YNNGrDjo+t+or1cI1MU3RUY4Nm2OcH4uI+O9cdroaLvmAXrNqUXko0GYrR2NG8vHBSI1E0/iDedzoHoiTKxtuCdxzqixPxHVLRGkioj8H8vv9DdZzQxDInZ2qIcMvzbV9vkPqcQ43bBgvBn+B9la4gor0P5ZpKbpjiMWJpQHI+q92fBIJ6xUU+zRk6aDvg5Sqqk5MwKzuUCBYT8yq9tzO30BjEUCdeFpd42VnEbto8MHyl0byaCVUyJjzA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- Delivery-date: Tue, 15 Jul 2025 08:52:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15/07/2025 10:51, Hari Limaye wrote:
> Hi Michal.
>
>>> + if ( base >= limit )
>> Given that limit is exclusive, to prevent empty regions, you would need to
>> check
>> for base >= (limit - 1), even though it's not really possible because today
>> we
>> require page aligned addresses (limit must be at least bigger or equal than
>> base
>> + PAGE_SIZE). That said, it can change one day, so I would suggest to modify
>> the
>> check. With that:
>>
>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>>
>> ~Michal
>>
>
> I think that this one is maybe also fine as-is?
Yes.
~Michal
|
