[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: Skip loops in init_pdx() when no PDX compression is used
- To: Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 14 Jul 2025 11:50:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7/oEeY6aWZJx6YayY36tPApUdbPvkshMJXjaeNmwbYM=; b=kYFYBMpEciXhE82nX8NCIRZ5MIkJmMELPXIbRlAp7pM6PKoowe7PDL+fSed/Mm7Icvm0Cs9dswdh/ezNwrCnSgzUl7plu3pMtHmBEAyLxckXlAHN6/BCSjvDoLXyRtbAayf0puzkFf/r1sBZDaQeGUXYtMVf/+BRnZSlpjQXrQTLDVT/LbIw0fSPvZwNoJqqHGD2KVtbU1oqttB/rGXLnaGgckNDAL2NXddFClMstRkEheIr9MdFIuS2KXY5gCyIcSWfkvwdH2yekhBJHlE/DAz5ROf88Sd6fWg6CMj2xzl4Sk7NZc+872nMsL+4E/8rgHhXq8vzKWHI2uGnvLB01g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CBnFv778k3A/W6DPnI+qBPXLbk/uoGa57O8dWfsw/3BdX6sBTPBrMSMfI7xp/XcbNXjJ7zLPBm8CdIwfk53ELY7LO+wicedzxqq6jxReosV+DtsYYtjXmvuIuPIkDow5R9yeDtGJiUWGzufF9lBEVAuhH/5oHqEEy3FcUbWwjZqe5EezDTM295DiLkO7p938X4oh5b1BUz6aN2HZziz33zU7L3Gz9kukBAZ3pfTQv/OKHKGdYkwoBFSghQzH2mg+J9WhJMJlWr1Ow4OlgIUbeXuq8hFwoJq6SaOUd5sSYp8/Le+/QOzN/gywYLH/2QC7gj7zirzw9APjmxgTokCubQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 14 Jul 2025 09:51:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/07/2025 11:45, Julien Grall wrote:
> Hi Michal,
>
> On 14/07/2025 08:37, Orzel, Michal wrote:
>>
>>
>> On 12/07/2025 12:29, Julien Grall wrote:
>>> Hi Michal,
>>>
>>> On 04/07/2025 08:54, Michal Orzel wrote:
>>>> When CONFIG_PDX_COMPRESSION=n, pdx_init_mask(), pdx_region_mask() and
>>>> pfn_pdx_hole_setup() are just stubs doing nothing. It does not make
>>>> sense to keep the two loops iterating over all the memory banks.
>>>
>>> I saw this was already committed. But I have a question. Wouldn't the
>>> compiler be able to optimize and remove the loops? Asking because we are
>>> trying to limit the number of #ifdef in the code hence why we have stubs.
>> Before submitting a patch I did disassembled init_pdx() with and without my
>> patch and in the latter case the compiler did not optimize out the loops.
>
> One more question. Was this in debug or non-debug build?
It was in debug build.
~Michal
|
