[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote: MISRA C Rule 5.5 states that: "Identifiers shall be distinct from macro names". Update ECLAIR configuration to deviate: - clashes in 'xen/include/xen/bitops.h'; - clashes in 'xen/include/xen/irq.h'; - clashes in 'xen/common/grant_table.c'. Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx> --- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.eclindex e8f513fbc5..a5d7b00094 100644 --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl@@ -117,6 +117,14 @@ it defines would (in the common case) be already defined. Peer reviewed by the c -config=MC3A2.R5.5,reports+={deliberate, "any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}-doc_end+-doc_begin="Clashes between function names and macros are deliberate for bitops functions, pirq_cleanup_check, update_gnttab_par and parse_gnttab_limit functions +and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function, +the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} Bitops violations are not inside "xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h" +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"} I would rather do (untested)-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"}+-doc_end + same as above -doc_begin="The type \"ret_t\" is deliberately defined multiple times, depending on the guest."-config=MC3A2.R5.6,reports+={deliberate,"any_area(any_loc(text(^.*ret_t.*$)))"}diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst index 0d56d45b66..fe05e4062e 100644 --- a/docs/misra/deviations.rst +++ b/docs/misra/deviations.rst @@ -142,6 +142,14 @@ Deviations related to MISRA C:2012 Rules: memmove. - Tagged as `deliberate` for ECLAIR. + * - R5.5+ - Clashes between function names and macros are deliberate for bitops functions, + pirq_cleanup_check, update_gnttab_par and parse_gnttab_limit functions and needed + to have a function-like macro that acts as a wrapper for the function to be + called. Before calling the function, the macro adds additional checks or + adjusts the number of parameters depending on the configuration.+ - Tagged as `deliberate` for ECLAIR. + * - R5.6- The type ret_t is deliberately defined multiple times depending on thetype of guest to service. -- Nicola Vetrini, B.Sc. Software Engineer BUGSENG (https://bugseng.com) LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |