[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v6 03/19] tools: optimize cpufreq average freq print


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Fri, 11 Jul 2025 11:50:50 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZZIVkKU+NVaxARBpqZ7HQ3xANg3Teflxal2nncwCBmE=; b=nZ0UbqtlG5sS699+7fdycIdxf1IiOJwClFK5pk1aq3C6z+50X0/NcazKQ14j+XhCnC78Zj30JWoPc0MIKRPZ5Hu5A4E7d5f4p+RlWrCt8B2swXaJ9oxK1U028mWglxFHkxKLdIlcBZ/P7v+Of8oWnQeqxh4KEq9aOzv7N59D/P06W2WnuW/fVcQsj+jpusoTuLBgw3QKhpdSueEwz2+NecSPI2AfSct9jr8HpKMYBSATgsRBRNP9hqXSwP6SsTOVWhsJ8KB6bPbWChkGIPALekbg82d1vEUCS0D33qQsmeM8MYwumNoLElugmrOhMM653qrdFD2IjwEkzvIOlbL4Pw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SaRWeRV7FrmAkXbdCRARbW83hbGaVVdkchjmpvtGOSOlXjd/x51gmRNu6dMcWZgzODtEmJVms4y58U9XWmdnmcpeS6HKwl0yrd3SLz4zpePiipVoQtYwHKOXL6QjAGzKAjEBk9tfCtJgoZt7EeXXI+s60Lamfu7XsCPx7ezgW1jrTuSn/JisnsoZ3S1B0IC71Ii0QWv8t+t+rYvXBv4PB7DXXEHIye+ZEk8cIazdlhUKx9i/6eK1O+LfOz0G8x9SVHTf5WBMWh+n8M+zI/GOnBYjgkTqQkUPgUmu6QVBoOmRqY8fCyt5mBOC2OxfJ2MDD+fvu+ipwBPisMq2xbRq1A==
  • Cc: <ray.huang@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 11 Jul 2025 03:51:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Unlike Cx/Px states, for which we need an extra loop to summerize residency (
sum_cx[]/sum_px[]), we could call get_avgfreq_by_cpuid() right before printing.
Also, with later introduction of CPPC mode, average frequency print shall
not depend on the existence of legacy P-states, so we remove "px_cap"
dependancy check.

Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
---
v3 -> v4:
- new commit
---
v4 -> v5:
- refactor title and commit message
- call get_avgfreq_by_cpuid() right before printing
---
v5 -> v6:
- remove "Fixes:xxx"
---
 tools/misc/xenpm.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c
index d5387f5f06..bbe45fa548 100644
--- a/tools/misc/xenpm.c
+++ b/tools/misc/xenpm.c
@@ -510,9 +510,6 @@ static void signal_int_handler(int signo)
                                  pxstat_start[i].pt[j].residency;
     }
 
-    for ( i = 0; i < max_cpu_nr; i++ )
-        get_avgfreq_by_cpuid(xc_handle, i, &avgfreq[i]);
-
     printf("Elapsed time (ms): %"PRIu64"\n", (usec_end - usec_start) / 1000UL);
     for ( i = 0; i < max_cpu_nr; i++ )
     {
@@ -553,7 +550,8 @@ static void signal_int_handler(int signo)
                         res / 1000000UL, 100UL * res / (double)sum_px[i]);
             }
         }
-        if ( px_cap && avgfreq[i] )
+        get_avgfreq_by_cpuid(xc_handle, i, &avgfreq[i]);
+        if ( avgfreq[i] )
             printf("  Avg freq\t%d\tKHz\n", avgfreq[i]);
     }
 
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.