[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 04/11] x86: Replace arch-specific boot_domain with the common one
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Thu, 10 Jul 2025 14:03:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vei1bKf+gNAQJPa66+43VmkUD6pDCl+qf3JZQrsfyfE=; b=E/hzxashFrmzTgstd6g703qm2CKt6oI4fJvbPj2N77g7ZORi92azsvCsMHh8lCoKC7tBRvdzAWkNQmibOxH2oH7y8ysevT9WnhJjFgp3bCdPIoMY1iJpQigtZAujObYVgOHp5TLDfNWC7xPtAJugWDTjFYtTUDSIiKBFa++lYWPNyKQ6k8phqD1MM2WsO3c9mcRwKXWrPxybRgUMns0EzRKuZor+zKHj63OrfR4VB32CEYSVXawOXwN1OPC/QUKCoEeiWWuUXRvkYXdncUf6oHqI4OxbYyErtlKMoUQlzhQFMKCBkOVH78Vfv+Sb5+d/IyxYCDqM/J9xrpFbWhGOyQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dN+lZjARuSRc4yYC8SI3Mso3vPs5h//z6SeecHoWZ/+7AiYTPBP+/vtzaB7Azlv+a6/nybOhcMDzjAk/LaPMFjZOIDC7LwTrzf+r6z2yZP0p8yw6za21582gEJmk1a1zbUDxZtovoQkK4fl3TMgIa32eGcMel9cJEOaARgQqsHQuuW/fVsvEkkXJyFHouFHUDopZAbf23sTBpDvMLVFlmaIlIvQTC7a+QV1SS9SzA6sno6DpTOnZuzvTQkBUomKQ6AU5vftqBkSK5SVPmngUbn1ZSeh6qaeN0YwKpO8NUozvkEXxGAcH77xUHGj2mTkfz9QHDS+S34VHXWC/9fHI8Q==
- Cc: Alejandro Vallejo <agarciav@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Michal Orzel" <michal.orzel@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Jul 2025 12:03:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed Jul 9, 2025 at 4:24 PM CEST, Jan Beulich wrote:
> On 08.07.2025 20:07, Alejandro Vallejo wrote:
>> --- a/xen/include/xen/bootfdt.h
>> +++ b/xen/include/xen/bootfdt.h
>> @@ -107,6 +107,10 @@ struct boot_domain {
>> struct boot_module *initrd;
>>
>> const char *cmdline;
>> +
>> +#if __has_include(<asm/bootfdt.h>)
>> + struct arch_boot_domain arch;
>> +#endif
>> };
>
> I fear I still don't follow this. In patch 1 you made domU a common-but-not-
> x86 field. Why can't domid, which is entirely generic, not similarly be a
> common-but-only-x86-for-now field? What is put in arch-specific structures
> should, in the common case at least, be truly (i.e. conceptually) be arch-
> specific imo.
>
> Jan
I tried to do the same with domU, but it's used by every other architecture so
it got silly adding the same code to 3 different arch-specific headers. I can
definitely move domid to the root structure under a similar ifdef.
Particularly when, as you very well point out, it's bound to be truly common
eventually.
Cheers,
Alejandro
|
